Commit 7ad2e02
doc,meta: allow Travis results for doc/comment changes
Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.
PR-URL: #30330
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 401d2e9 commit 7ad2e02
1 file changed
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -172,8 +172,9 @@ the comment anyway to avoid any doubt. | |||
| 172 | 172 | All fixes must have a test case which demonstrates the defect. The test should | |
| 173 | 173 | fail before the change, and pass after the change. | |
| 174 | 174 | ||
| 175 | - All pull requests must pass continuous integration tests on the | ||
| 176 | - [project CI server](https://ci.nodejs.org/). | ||
| 175 | + All pull requests must pass continuous integration tests. Code changes must pass | ||
| 176 | + on [project CI server](https://ci.nodejs.org/). Pull requests that only change | ||
| 177 | + documentation and comments can use Travis CI results. | ||
| 177 | 178 | ||
| 178 | 179 | Do not land any pull requests without passing (green or yellow) CI runs. If | |
| 179 | 180 | there are CI failures unrelated to the change in the pull request, try "Resume | |
@@ -187,10 +188,6 @@ everything else. | |||
| 187 | 188 | is the CI job to test pull requests. It runs the `build-ci` and `test-ci` | |
| 188 | 189 | targets on all supported platforms. | |
| 189 | 190 | ||
| 190 | - * [`node-test-pull-request-lite-pipeline`](https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/) | ||
| 191 | - runs the linter job. It also runs the tests on a very fast host. This is useful | ||
| 192 | - for changes that only affect comments or documentation. | ||
| 193 | - | ||
| 194 | 191 | * [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/) | |
| 195 | 192 | uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run | |
| 196 | 193 | `npm install && npm test` on a large selection of common modules. This is | |
0 commit comments