Commit 7af8738
test: fix flaky test-child-process-exec-timeout
At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM
to a process that is still starting up kills it with SIGKILL instead of
SIGTERM.
PR-URL: #12159
Refs: libuv/libuv#1226
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent d007427 commit 7af8738
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,7 +18,13 @@ const cmd = `${process.execPath} ${__filename} child`; | |||
| 18 | 18 | cp.exec(cmd, { timeout: 1 }, common.mustCall((err, stdout, stderr) => { | |
| 19 | 19 | assert.strictEqual(err.killed, true); | |
| 20 | 20 | assert.strictEqual(err.code, null); | |
| 21 | - assert.strictEqual(err.signal, 'SIGTERM'); | ||
| 21 | + // At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a | ||
| 22 | + // process that is still starting up kills it with SIGKILL instead of SIGTERM. | ||
| 23 | + // See: https://github.com/libuv/libuv/issues/1226 | ||
| 24 | + if (common.isOSX) | ||
| 25 | + assert.ok(err.signal === 'SIGTERM' || err.signal === 'SIGKILL'); | ||
| 26 | + else | ||
| 27 | + assert.strictEqual(err.signal, 'SIGTERM'); | ||
| 22 | 28 | assert.strictEqual(err.cmd, cmd); | |
| 23 | 29 | assert.strictEqual(stdout.trim(), ''); | |
| 24 | 30 | assert.strictEqual(stderr.trim(), ''); | |
0 commit comments