tools: allow selecting test subsystems with numbers in their names · nodejs/node@7b94982 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7b94982

Browse filesBrowse the repository at this point in the historyBrowse files

RaisinTen

authored and

targos

committed

tools: allow selecting test subsystems with numbers in their names

Previously, selecting subsystems with numbers in their names, like http2, weren't matched due to a restrictive regex: ``` $ tools/test.py http2 No tests to run. ``` The regex now allows digits, so these tests run as expected: ``` $ tools/test.py http2 [00:17|% 100|+ 286|- 0]: Done All tests passed. ``` Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #59242 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

1 parent 6a47ff4 commit 7b94982
Copy full SHA for 7b94982

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tools
  • test.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tools/test.py‎

Copy file name to clipboardExpand all lines: tools/test.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1605,7 +1605,7 @@ def ArgsToTestPaths(test_root, args, suites):
1605	1605	if len(args) == 0 or 'default' in args:
1606	1606	def_suites = [s for s in suites if s not in IGNORED_SUITES]
1607	1607	args = [a for a in args if a != 'default'] + def_suites
1608		- subsystem_regex = re.compile(r'^[a-zA-Z-]*$')
	1608	+ subsystem_regex = re.compile(r'^[a-zA-Z0-9-]*$')
1609	1609	check = lambda arg: subsystem_regex.match(arg) and (arg not in suites)
1610	1610	mapped_args = ["*/test*-%s-*" % arg if check(arg) else arg for arg in args]
1611	1611	paths = [SplitPath(NormalizePath(a)) for a in mapped_args]

0 commit comments

Comments

0 (0)