FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: Fix crash in net benchmarks · nodejs/node@7b9ae70 · GitHub

/ node Public

Commit 7b9ae70

Browse files
Matt Loring
authored and
Fishrock123
committed
benchmark: Fix crash in net benchmarks
Net benchmarks create partial event emitters that do not have all of the required event emitter functions. They currently mock out `on`, `once`, and `emit` functions. This change mocks out `prependListener` as well to avoid crashing in `_stream_readable`. PR-URL: https://www.github.com/nodejs/node/pull/6407 Fixes: https://www.github.com/nodejs/node/issues/6405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Matthew Loring <mattloring@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 11e7cc5 commit 7b9ae70

4 files changed

Lines changed: 4 additions & 0 deletions

File tree

‎benchmark/net/net-c2s-cork.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) {
6262
Writer.prototype.on = function() {};
6363
Writer.prototype.once = function() {};
6464
Writer.prototype.emit = function() {};
65+
Writer.prototype.prependListener = function() {};
6566

6667
function server() {
6768
var writer = new Writer();

‎benchmark/net/net-c2s.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) {
6262
Writer.prototype.on = function() {};
6363
Writer.prototype.once = function() {};
6464
Writer.prototype.emit = function() {};
65+
Writer.prototype.prependListener = function() {};
6566

6667

6768
function Reader() {

‎benchmark/net/net-pipe.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) {
6262
Writer.prototype.on = function() {};
6363
Writer.prototype.once = function() {};
6464
Writer.prototype.emit = function() {};
65+
Writer.prototype.prependListener = function() {};
6566

6667

6768
function Reader() {

‎benchmark/net/net-s2c.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) {
6262
Writer.prototype.on = function() {};
6363
Writer.prototype.once = function() {};
6464
Writer.prototype.emit = function() {};
65+
Writer.prototype.prependListener = function() {};
6566

6667

6768
function Reader() {

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL