Commit 7ba3599
tools: fix inspector-check reporting
Currently the inspector-check rule does not store the node when the
usage of a require('inspector') is done. This means that it is not
possible to disable this rule. For example, if you add the following to
a test that uses the inspector module:
//common.skipIfInspectorDisabled();
/* eslint-disable inspector-check */
This will not disable the check and there will still be a lint error
reported.
This commit stores the node where the require statement is done which
allows for the rule to also be disabled.
PR-URL: #16902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 809dc09 commit 7ba3599
1 file changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -14,12 +14,12 @@ const msg = 'Please add a skipIfInspectorDisabled() call to allow this ' + | |||
| 14 | 14 | 'test to be skippped when Node is built \'--without-inspector\'.'; | |
| 15 | 15 | ||
| 16 | 16 | module.exports = function(context) { | |
| 17 | - var usesInspector = false; | ||
| 17 | + const missingCheckNodes = []; | ||
| 18 | 18 | var hasInspectorCheck = false; | |
| 19 | 19 | ||
| 20 | 20 | function testInspectorUsage(context, node) { | |
| 21 | 21 | if (utils.isRequired(node, ['inspector'])) { | |
| 22 | - usesInspector = true; | ||
| 22 | + missingCheckNodes.push(node); | ||
| 23 | 23 | } | |
| 24 | 24 | } | |
| 25 | 25 | ||
@@ -30,8 +30,10 @@ module.exports = function(context) { | |||
| 30 | 30 | } | |
| 31 | 31 | ||
| 32 | 32 | function reportIfMissing(context, node) { | |
| 33 | - if (usesInspector && !hasInspectorCheck) { | ||
| 34 | - context.report(node, msg); | ||
| 33 | + if (!hasInspectorCheck) { | ||
| 34 | + missingCheckNodes.forEach((node) => { | ||
| 35 | + context.report(node, msg); | ||
| 36 | + }); | ||
| 35 | 37 | } | |
| 36 | 38 | } | |
| 37 | 39 | ||
0 commit comments