FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix MSVC 2022 Release compilation · nodejs/node@7bae433 · GitHub

/ node Public

Commit 7bae433

Browse files
vmoroz
authored and
juanarbol
committed
build: fix MSVC 2022 Release compilation
PR-URL: #46228 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent fc15ac9 commit 7bae433

4 files changed

Lines changed: 20 additions & 2 deletions

File tree

‎.github/workflows/build-windows.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
if: github.event.pull_request.draft == false
3535
strategy:
3636
matrix:
37-
windows: [windows-2019]
37+
windows: [windows-2019, windows-2022]
3838
fail-fast: false
3939
runs-on: ${{ matrix.windows }}
4040
steps:

‎.github/workflows/coverage-windows.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ permissions:
3737
jobs:
3838
coverage-windows:
3939
if: github.event.pull_request.draft == false
40-
runs-on: windows-2019
40+
runs-on: windows-2022
4141
steps:
4242
- uses: actions/checkout@v3
4343
with:

‎tools/v8_gypfiles/directory.build.props‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<Project>
3+
<ItemDefinitionGroup>
4+
<MARMASM>
5+
<!-- Works around a situation when we preprocess file in $(IntDir). In such case the output file is the same as input file
6+
and we get access violation. Appending '.pp' file extension to the output file name resolves this issue. -->
7+
<PreprocessedFileName Condition="'%(PreprocessedFileName)' == ''">$(IntDir)%(FileName)%(Extension).pp</PreprocessedFileName>
8+
</MARMASM>
9+
</ItemDefinitionGroup>
10+
</Project>

‎tools/v8_gypfiles/v8.gyp‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1437,6 +1437,14 @@
14371437
['want_separate_host_toolset', {
14381438
'toolsets': ['host'],
14391439
}],
1440+
['OS=="win"', {
1441+
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
1442+
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
1443+
'sources': [
1444+
'<(_msvs_precompiled_header)',
1445+
'<(_msvs_precompiled_source)',
1446+
],
1447+
}],
14401448
],
14411449
}, # mksnapshot
14421450
{

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL