buffer: graduate File from experimental and expose as global · nodejs/node@7bc0e6a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7bc0e6a

Browse filesBrowse the repository at this point in the historyBrowse files

KhafraDev

authored

buffer: graduate File from experimental and expose as global

PR-URL: #47153 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 202a9fa commit 7bc0e6a
Copy full SHA for 7bc0e6a

5 files changed

+18-5Lines changed: 18 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • buffer.md
  • globals.md
• lib
  • .eslintrc.yaml
  • internal
    • bootstrap/web
      • exposed-window-or-worker.js
    • file.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/buffer.md‎

Copy file name to clipboardExpand all lines: doc/api/buffer.md

+4-2Lines changed: 4 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -5054,10 +5054,12 @@ See [`Buffer.from(string[, encoding])`][`Buffer.from(string)`].
5054	5054	added:
5055	5055	- v19.2.0
5056	5056	- v18.13.0
	5057	+ changes:
	5058	+ - version: REPLACEME
	5059	+ pr-url: https://github.com/nodejs/node/pull/47153
	5060	+ description: No longer experimental.
5057	5061	-->
5058	5062
5059		- > Stability: 1 - Experimental
5060		-
5061	5063	* Extends: {Blob}
5062	5064
5063	5065	A [`File`][] provides information about files.

Collapse file

‎doc/api/globals.md‎

Copy file name to clipboardExpand all lines: doc/api/globals.md

+10Lines changed: 10 additions & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -474,6 +474,16 @@ changes:
474	474
475	475	A browser-compatible implementation of the [`fetch()`][] function.
476	476
	477	+ ## Class: `File`
	478	+
	479	+ <!-- YAML
	480	+ added: REPLACEME
	481	+ -->
	482	+
	483	+ <!-- type=global -->
	484	+
	485	+ See {File}.
	486	+
477	487	## Class `FormData`
478	488
479	489	<!-- YAML

Collapse file

‎lib/.eslintrc.yaml‎

Copy file name to clipboardExpand all lines: lib/.eslintrc.yaml

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -59,6 +59,8 @@ rules:
59	59	message: Use `const { Event } = require('internal/event_target');` instead of the global.
60	60	- name: EventTarget
61	61	message: Use `const { EventTarget } = require('internal/event_target');` instead of the global.
	62	+ - name: File
	63	+ message: Use `const { File } = require('buffer');` instead of the global.
62	64	- name: FormData
63	65	message: Use `const { FormData } = require('internal/deps/undici/undici');` instead of the global.
64	66	- name: Headers

Collapse file

‎lib/internal/bootstrap/web/exposed-window-or-worker.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/web/exposed-window-or-worker.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -34,6 +34,8 @@ exposeLazyInterfaces(globalThis, 'internal/worker/io', [
34	34	defineLazyProperties(globalThis, 'buffer', ['atob', 'btoa']);
35	35	// https://www.w3.org/TR/FileAPI/#dfn-Blob
36	36	exposeLazyInterfaces(globalThis, 'internal/blob', ['Blob']);
	37	+ // https://www.w3.org/TR/FileAPI/#dfn-file
	38	+ exposeLazyInterfaces(globalThis, 'internal/file', ['File']);
37	39	// https://www.w3.org/TR/hr-time-2/#the-performance-attribute
38	40	exposeLazyInterfaces(globalThis, 'perf_hooks', [
39	41	'Performance', 'PerformanceEntry', 'PerformanceMark', 'PerformanceMeasure',

Collapse file

‎lib/internal/file.js‎

Copy file name to clipboardExpand all lines: lib/internal/file.js

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -13,7 +13,6 @@ const {
13	13
14	14	const {
15	15	customInspectSymbol: kInspect,
16		- emitExperimentalWarning,
17	16	kEnumerableProperty,
18	17	kEmptyObject,
19	18	toUSVString,
@@ -37,8 +36,6 @@ class File extends Blob {
37	36	#lastModified;
38	37
39	38	constructor(fileBits, fileName, options = kEmptyObject) {
40		- emitExperimentalWarning('buffer.File');
41		-
42	39	if (arguments.length < 2) {
43	40	throw new ERR_MISSING_ARGS('fileBits', 'fileName');
44	41	}

0 commit comments

Comments

0 (0)