Commit 7bceb4f
test: add message verification on assert.throws
Add regular expression for error message validation to instances of
assert.throws() in test-assert.js.
PR-URL: #10890
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 1c223ec commit 7bceb4f
1 file changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -92,11 +92,16 @@ assert.doesNotThrow(makeBlock(a.deepEqual, /a/g, /a/g)); | |||
| 92 | 92 | assert.doesNotThrow(makeBlock(a.deepEqual, /a/i, /a/i)); | |
| 93 | 93 | assert.doesNotThrow(makeBlock(a.deepEqual, /a/m, /a/m)); | |
| 94 | 94 | assert.doesNotThrow(makeBlock(a.deepEqual, /a/igm, /a/igm)); | |
| 95 | - assert.throws(makeBlock(a.deepEqual, /ab/, /a/)); | ||
| 96 | - assert.throws(makeBlock(a.deepEqual, /a/g, /a/)); | ||
| 97 | - assert.throws(makeBlock(a.deepEqual, /a/i, /a/)); | ||
| 98 | - assert.throws(makeBlock(a.deepEqual, /a/m, /a/)); | ||
| 99 | - assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im)); | ||
| 95 | + assert.throws(makeBlock(a.deepEqual, /ab/, /a/), | ||
| 96 | + /^AssertionError: \/ab\/ deepEqual \/a\/$/); | ||
| 97 | + assert.throws(makeBlock(a.deepEqual, /a/g, /a/), | ||
| 98 | + /^AssertionError: \/a\/g deepEqual \/a\/$/); | ||
| 99 | + assert.throws(makeBlock(a.deepEqual, /a/i, /a/), | ||
| 100 | + /^AssertionError: \/a\/i deepEqual \/a\/$/); | ||
| 101 | + assert.throws(makeBlock(a.deepEqual, /a/m, /a/), | ||
| 102 | + /^AssertionError: \/a\/m deepEqual \/a\/$/); | ||
| 103 | + assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im), | ||
| 104 | + /^AssertionError: \/a\/gim deepEqual \/a\/im$/); | ||
| 100 | 105 | ||
| 101 | 106 | { | |
| 102 | 107 | const re1 = /a/g; | |
0 commit comments