Commit 7c3486b
src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.
PR-URL: #10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>1 parent c13c9ff commit 7c3486b
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -47,6 +47,9 @@ | |||
| 47 | 47 | (minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION)) | |
| 48 | 48 | ||
| 49 | 49 | /** | |
| 50 | + * Node.js will refuse to load modules that weren't compiled against its own | ||
| 51 | + * module ABI number, exposed as the process.versions.modules property. | ||
| 52 | + * | ||
| 50 | 53 | * When this version number is changed, node.js will refuse | |
| 51 | 54 | * to load older modules. This should be done whenever | |
| 52 | 55 | * an API is broken in the C++ side, including in v8 or | |
0 commit comments