Commit 7c43da3
http2: core.js replace var with let
const has to be used in for in loop
PR-URL: #30403
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent de20c53 commit 7c43da3
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -582,7 +582,7 @@ function onOrigin(origins) { | |||
| 582 | 582 | if (!session.encrypted || session.destroyed) | |
| 583 | 583 | return undefined; | |
| 584 | 584 | const originSet = initOriginSet(session); | |
| 585 | - for (var n = 0; n < origins.length; n++) | ||
| 585 | + for (let n = 0; n < origins.length; n++) | ||
| 586 | 586 | originSet.add(origins[n]); | |
| 587 | 587 | session.emit('origin', origins); | |
| 588 | 588 | } | |
@@ -1496,7 +1496,7 @@ class ServerHttp2Session extends Http2Session { | |||
| 1496 | 1496 | let arr = ''; | |
| 1497 | 1497 | let len = 0; | |
| 1498 | 1498 | const count = origins.length; | |
| 1499 | - for (var i = 0; i < count; i++) { | ||
| 1499 | + for (let i = 0; i < count; i++) { | ||
| 1500 | 1500 | let origin = origins[i]; | |
| 1501 | 1501 | if (typeof origin === 'string') { | |
| 1502 | 1502 | origin = (new URL(origin)).origin; | |
@@ -2128,7 +2128,7 @@ function processHeaders(oldHeaders) { | |||
| 2128 | 2128 | if (oldHeaders !== null && oldHeaders !== undefined) { | |
| 2129 | 2129 | const hop = hasOwnProperty.bind(oldHeaders); | |
| 2130 | 2130 | // This loop is here for performance reason. Do not change. | |
| 2131 | - for (var key in oldHeaders) { | ||
| 2131 | + for (const key in oldHeaders) { | ||
| 2132 | 2132 | if (hop(key)) { | |
| 2133 | 2133 | headers[key] = oldHeaders[key]; | |
| 2134 | 2134 | } | |
0 commit comments