Commit 7c51cec
util: use assert for unreachable code
Great effort is taken to keep `util.inspect()` from throwing while
inspecting a linked list or other items that require recursion. It is
likely still possible at this time to cause a throw with prototype
pollution, but that will change soon when the code is modified to use
primordials.
This commit instructs our coverage to not be concerned about not being
able to reach the throwing-an-error code and changes the throw there to
an assert so users will be instructed to open a bug with Node.js should
they manage to cause the code to throw.
PR-URL: #37249
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent ebf3597 commit 7c51cec
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1360,7 +1360,8 @@ function handleMaxCallStackSize(ctx, err, constructorName, indentationLvl) { | |||
| 1360 | 1360 | 'special' | |
| 1361 | 1361 | ); | |
| 1362 | 1362 | } | |
| 1363 | - throw err; | ||
| 1363 | + /* c8 ignore next */ | ||
| 1364 | + assert.fail(err.stack); | ||
| 1364 | 1365 | } | |
| 1365 | 1366 | ||
| 1366 | 1367 | function formatNumber(fn, value) { | |
0 commit comments