test: fix race condition in test-child-process-bad-stdio · nodejs/node@7c9fa11 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7c9fa11

Browse filesBrowse the repository at this point in the historyBrowse files

cjihrig

authored and

targos

committed

test: fix race condition in test-child-process-bad-stdio

test-child-process-bad-stdio.js contains a race condition between a timeout in the test process and a timeout in the spawned child process. This commit addresses the race condition by having the child process wait indefinitely to be killed. PR-URL: #56845 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

1 parent 3999786 commit 7c9fa11
Copy full SHA for 7c9fa11

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-child-process-bad-stdio.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-child-process-bad-stdio.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-bad-stdio.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -3,7 +3,7 @@
3	3	const common = require('../common');
4	4
5	5	if (process.argv[2] === 'child') {
6		- setTimeout(() => {}, common.platformTimeout(100));
	6	+ setTimeout(() => {}, common.platformTimeout(1000));
7	7	return;
8	8	}
9	9

0 commit comments

Comments

0 (0)