Commit 7cdcca7
committed
deps: cherry-pick 866ee63 from upstream V8
Original commit message:
[string] Re-enable result caching for String.p.split
Runtime::kStringSplit's result caching is only enabled when limit equals
kMaxUInt32.
BUG=v8:6463
Review-Url: https://codereview.chromium.org/2923183002
Cr-Commit-Position: refs/heads/master@{#45724}
PR-URL: #13630
Fixes: #13445
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 8f907b6 commit 7cdcca7
1 file changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1190,14 +1190,11 @@ TF_BUILTIN(StringPrototypeSplit, StringBuiltinsAssembler) { | |||
| 1190 | 1190 | }); | |
| 1191 | 1191 | ||
| 1192 | 1192 | // String and integer conversions. | |
| 1193 | - // TODO(jgruber): The old implementation used Uint32Max instead of SmiMax - | ||
| 1194 | - // but AFAIK there should not be a difference since arrays are capped at Smi | ||
| 1195 | - // lengths. | ||
| 1196 | 1193 | ||
| 1197 | 1194 | Callable tostring_callable = CodeFactory::ToString(isolate()); | |
| 1198 | 1195 | Node* const subject_string = CallStub(tostring_callable, context, receiver); | |
| 1199 | 1196 | Node* const limit_number = | |
| 1200 | - Select(IsUndefined(limit), [=]() { return SmiConstant(Smi::kMaxValue); }, | ||
| 1197 | + Select(IsUndefined(limit), [=]() { return NumberConstant(kMaxUInt32); }, | ||
| 1201 | 1198 | [=]() { return ToUint32(context, limit); }, | |
| 1202 | 1199 | MachineRepresentation::kTagged); | |
| 1203 | 1200 | Node* const separator_string = | |
0 commit comments