src: include `node_api_types.h` instead of `node_api.h` in `node.h` · nodejs/node@7d2bc52 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7d2bc52

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

committed

src: include node_api_types.h instead of node_api.h in node.h

Including `node.h` should not result in all of Node-API also being available to callers. Users who want `node_api.h` contents should explicitly include that header. We currently include it specifically for `napi_addon_register_func`; by moving that into `node_api_types.h` and including that instead, we can reduce unintentionally included API surface a lot. Refs: #60345 (comment) PR-URL: #60496 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

1 parent 36c082b commit 7d2bc52
Copy full SHA for 7d2bc52

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node.h‎

Copy file name to clipboardExpand all lines: src/node.h

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -76,7 +76,7 @@
76	76	#include "v8-platform.h" // NOLINT(build/include_order)
77	77	#include "node_version.h" // NODE_MODULE_VERSION
78	78
79		- #include "node_api.h"
	79	+ #include "node_api_types.h" // napi_addon_register_func
80	80
81	81	#include <functional>
82	82	#include <memory>
@@ -124,6 +124,7 @@
124	124
125	125	// Forward-declare libuv loop
126	126	struct uv_loop_s;
	127	+ struct napi_module;
127	128
128	129	// Forward-declare these functions now to stop MSVS from becoming
129	130	// terminally confused when it's done in node_internals.h

0 commit comments

Comments

0 (0)