Commit 7d5686d
tools: enable ESLint recommended configuration
PR-URL: #41463
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>1 parent ecf3b6d commit 7d5686d
1 file changed
Lines changed: 8 additions & 51 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,7 +35,7 @@ Module._findPath = (request, paths, isMain) => { | |||
| 35 | 35 | ||
| 36 | 36 | module.exports = { | |
| 37 | 37 | root: true, | |
| 38 | - extends: ['plugin:jsdoc/recommended'], | ||
| 38 | + extends: ['eslint:recommended', 'plugin:jsdoc/recommended'], | ||
| 39 | 39 | plugins: ['jsdoc', 'markdown', 'node-core'], | |
| 40 | 40 | parser: '@babel/eslint-parser', | |
| 41 | 41 | parserOptions: { | |
@@ -142,17 +142,14 @@ module.exports = { | |||
| 142 | 142 | 'comma-spacing': 'error', | |
| 143 | 143 | 'comma-style': 'error', | |
| 144 | 144 | 'computed-property-spacing': 'error', | |
| 145 | - 'constructor-super': 'error', | ||
| 146 | 145 | 'default-case-last': 'error', | |
| 147 | 146 | 'dot-location': ['error', 'property'], | |
| 148 | 147 | 'dot-notation': 'error', | |
| 149 | 148 | 'eol-last': 'error', | |
| 150 | 149 | 'eqeqeq': ['error', 'smart'], | |
| 151 | - 'for-direction': 'error', | ||
| 152 | 150 | 'func-call-spacing': 'error', | |
| 153 | 151 | 'func-name-matching': 'error', | |
| 154 | 152 | 'func-style': ['error', 'declaration', { allowArrowFunctions: true }], | |
| 155 | - 'getter-return': 'error', | ||
| 156 | 153 | 'indent': ['error', 2, { | |
| 157 | 154 | ArrayExpression: 'first', | |
| 158 | 155 | CallExpression: { arguments: 'first' }, | |
@@ -174,49 +171,20 @@ module.exports = { | |||
| 174 | 171 | tabWidth: 2, | |
| 175 | 172 | }], | |
| 176 | 173 | 'new-parens': 'error', | |
| 177 | - 'no-async-promise-executor': 'error', | ||
| 178 | - 'no-case-declarations': 'error', | ||
| 179 | - 'no-class-assign': 'error', | ||
| 180 | 174 | 'no-confusing-arrow': 'error', | |
| 181 | - 'no-const-assign': 'error', | ||
| 182 | 175 | 'no-constant-condition': ['error', { checkLoops: false }], | |
| 183 | 176 | 'no-constructor-return': 'error', | |
| 184 | - 'no-control-regex': 'error', | ||
| 185 | - 'no-debugger': 'error', | ||
| 186 | - 'no-delete-var': 'error', | ||
| 187 | - 'no-dupe-args': 'error', | ||
| 188 | - 'no-dupe-class-members': 'error', | ||
| 189 | - 'no-dupe-keys': 'error', | ||
| 190 | - 'no-dupe-else-if': 'error', | ||
| 191 | - 'no-duplicate-case': 'error', | ||
| 192 | 177 | 'no-duplicate-imports': 'error', | |
| 193 | 178 | 'no-else-return': ['error', { allowElseIf: true }], | |
| 194 | - 'no-empty-character-class': 'error', | ||
| 195 | - 'no-ex-assign': 'error', | ||
| 196 | - 'no-extra-boolean-cast': 'error', | ||
| 197 | 179 | 'no-extra-parens': ['error', 'functions'], | |
| 198 | - 'no-extra-semi': 'error', | ||
| 199 | - 'no-fallthrough': 'error', | ||
| 200 | - 'no-func-assign': 'error', | ||
| 201 | - 'no-global-assign': 'error', | ||
| 202 | - 'no-invalid-regexp': 'error', | ||
| 203 | - 'no-irregular-whitespace': 'error', | ||
| 204 | 180 | 'no-lonely-if': 'error', | |
| 205 | - 'no-loss-of-precision': 'error', | ||
| 206 | - 'no-misleading-character-class': 'error', | ||
| 207 | 181 | 'no-mixed-requires': 'error', | |
| 208 | - 'no-mixed-spaces-and-tabs': 'error', | ||
| 209 | 182 | 'no-multi-spaces': ['error', { ignoreEOLComments: true }], | |
| 210 | 183 | 'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }], | |
| 211 | 184 | 'no-new-require': 'error', | |
| 212 | - 'no-new-symbol': 'error', | ||
| 213 | - 'no-nonoctal-decimal-escape': 'error', | ||
| 214 | - 'no-obj-calls': 'error', | ||
| 215 | - 'no-octal': 'error', | ||
| 216 | 185 | 'no-path-concat': 'error', | |
| 217 | 186 | 'no-proto': 'error', | |
| 218 | 187 | 'no-redeclare': ['error', { 'builtinGlobals': false }], | |
| 219 | - 'no-regex-spaces': 'error', | ||
| 220 | 188 | 'no-restricted-modules': ['error', 'sys'], | |
| 221 | 189 | /* eslint-disable max-len */ | |
| 222 | 190 | 'no-restricted-properties': [ | |
@@ -273,41 +241,26 @@ module.exports = { | |||
| 273 | 241 | ], | |
| 274 | 242 | /* eslint-enable max-len */ | |
| 275 | 243 | 'no-return-await': 'error', | |
| 276 | - 'no-self-assign': 'error', | ||
| 277 | 244 | 'no-self-compare': 'error', | |
| 278 | - 'no-setter-return': 'error', | ||
| 279 | - 'no-shadow-restricted-names': 'error', | ||
| 280 | - 'no-sparse-arrays': 'error', | ||
| 281 | 245 | 'no-tabs': 'error', | |
| 282 | 246 | 'no-template-curly-in-string': 'error', | |
| 283 | - 'no-this-before-super': 'error', | ||
| 284 | 247 | 'no-throw-literal': 'error', | |
| 285 | 248 | 'no-trailing-spaces': 'error', | |
| 286 | 249 | 'no-undef': ['error', { typeof: true }], | |
| 287 | 250 | 'no-undef-init': 'error', | |
| 288 | - 'no-unexpected-multiline': 'error', | ||
| 289 | - 'no-unreachable': 'error', | ||
| 290 | - 'no-unsafe-finally': 'error', | ||
| 291 | - 'no-unsafe-negation': 'error', | ||
| 292 | - 'no-unsafe-optional-chaining': 'error', | ||
| 293 | 251 | 'no-unused-expressions': ['error', { allowShortCircuit: true }], | |
| 294 | - 'no-unused-labels': 'error', | ||
| 295 | 252 | 'no-unused-vars': ['error', { args: 'none', caughtErrors: 'all' }], | |
| 296 | 253 | 'no-use-before-define': ['error', { | |
| 297 | 254 | classes: true, | |
| 298 | 255 | functions: false, | |
| 299 | 256 | variables: false, | |
| 300 | 257 | }], | |
| 301 | - 'no-useless-backreference': 'error', | ||
| 302 | 258 | 'no-useless-call': 'error', | |
| 303 | - 'no-useless-catch': 'error', | ||
| 304 | 259 | 'no-useless-concat': 'error', | |
| 305 | 260 | 'no-useless-constructor': 'error', | |
| 306 | - 'no-useless-escape': 'error', | ||
| 307 | 261 | 'no-useless-return': 'error', | |
| 308 | 262 | 'no-void': 'error', | |
| 309 | 263 | 'no-whitespace-before-property': 'error', | |
| 310 | - 'no-with': 'error', | ||
| 311 | 264 | 'object-curly-newline': 'error', | |
| 312 | 265 | 'object-curly-spacing': ['error', 'always'], | |
| 313 | 266 | 'one-var': ['error', { initialized: 'never' }], | |
@@ -322,7 +275,6 @@ module.exports = { | |||
| 322 | 275 | 'quotes': ['error', 'single', { avoidEscape: true }], | |
| 323 | 276 | 'quote-props': ['error', 'consistent'], | |
| 324 | 277 | 'rest-spread-spacing': 'error', | |
| 325 | - 'require-yield': 'error', | ||
| 326 | 278 | 'semi': 'error', | |
| 327 | 279 | 'semi-spacing': 'error', | |
| 328 | 280 | 'space-before-blocks': ['error', 'always'], | |
@@ -342,10 +294,15 @@ module.exports = { | |||
| 342 | 294 | 'symbol-description': 'error', | |
| 343 | 295 | 'template-curly-spacing': 'error', | |
| 344 | 296 | 'unicode-bom': 'error', | |
| 345 | - 'use-isnan': 'error', | ||
| 346 | 297 | 'valid-typeof': ['error', { requireStringLiterals: true }], | |
| 347 | 298 | ||
| 348 | - // JSDoc rules | ||
| 299 | + // ESLint recommended rules that we disable | ||
| 300 | + 'no-cond-assign': 'off', | ||
| 301 | + 'no-empty': 'off', | ||
| 302 | + 'no-inner-declarations': 'off', | ||
| 303 | + 'no-prototype-builtins': 'off', | ||
| 304 | + | ||
| 305 | + // JSDoc recommended rules that we disable | ||
| 349 | 306 | 'jsdoc/require-jsdoc': 'off', | |
| 350 | 307 | 'jsdoc/require-param-description': 'off', | |
| 351 | 308 | 'jsdoc/newline-after-description': 'off', | |
0 commit comments