Commit 7d9f1f3
http2: fix ping callback
In case there was no ack, the callback would have returned
more than the error as return value. This makes sure that is not
the case anymore.
PR-URL: #20311
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent 5542a98 commit 7d9f1f3
1 file changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -704,8 +704,11 @@ const proxySocketHandler = { | |||
| 704 | 704 | // data received on the PING acknowlegement. | |
| 705 | 705 | function pingCallback(cb) { | |
| 706 | 706 | return function pingCallback(ack, duration, payload) { | |
| 707 | - const err = ack ? null : new ERR_HTTP2_PING_CANCEL(); | ||
| 708 | - cb(err, duration, payload); | ||
| 707 | + if (ack) { | ||
| 708 | + cb(null, duration, payload); | ||
| 709 | + } else { | ||
| 710 | + cb(new ERR_HTTP2_PING_CANCEL()); | ||
| 711 | + } | ||
| 709 | 712 | }; | |
| 710 | 713 | } | |
| 711 | 714 | ||
0 commit comments