Commit 7dbb0d0
buffer: fix dataview-set benchmark
Improves numbers up to 4x by avoiding repetitive dynamic method lookup.
PR-URL: #6922
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>1 parent 20d3378 commit 7dbb0d0
1 file changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -40,18 +40,20 @@ function main(conf) { | |||
| 40 | 40 | } | |
| 41 | 41 | ||
| 42 | 42 | function benchInt(dv, fn, len, le) { | |
| 43 | - var m = mod[fn]; | ||
| 43 | + const m = mod[fn]; | ||
| 44 | + const method = dv[fn]; | ||
| 44 | 45 | bench.start(); | |
| 45 | 46 | for (var i = 0; i < len; i++) { | |
| 46 | - dv[fn](0, i % m, le); | ||
| 47 | + method.call(dv, 0, i % m, le); | ||
| 47 | 48 | } | |
| 48 | 49 | bench.end(len / 1e6); | |
| 49 | 50 | } | |
| 50 | 51 | ||
| 51 | 52 | function benchFloat(dv, fn, len, le) { | |
| 53 | + const method = dv[fn]; | ||
| 52 | 54 | bench.start(); | |
| 53 | 55 | for (var i = 0; i < len; i++) { | |
| 54 | - dv[fn](0, i * 0.1, le); | ||
| 56 | + method.call(dv, 0, i * 0.1, le); | ||
| 55 | 57 | } | |
| 56 | 58 | bench.end(len / 1e6); | |
| 57 | 59 | } | |
0 commit comments