Commit 7dd8165
src: lock the thread properly in snapshot builder
Otherwise it can crash DCHECK when V8 expects that at least someone
is locking the current thread.
PR-URL: #56327
Fixes: nodejs/node-v8#294
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 2a0fbd8 commit 7dd8165
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -962,6 +962,8 @@ ExitCode BuildSnapshotWithoutCodeCache( | |||
| 962 | 962 | } | |
| 963 | 963 | ||
| 964 | 964 | Isolate* isolate = setup->isolate(); | |
| 965 | + v8::Locker locker(isolate); | ||
| 966 | + | ||
| 965 | 967 | { | |
| 966 | 968 | HandleScope scope(isolate); | |
| 967 | 969 | TryCatch bootstrapCatch(isolate); | |
0 commit comments