tools: only report commit validation failure on Slack · nodejs/node@7e95edc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7e95edc

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

RafaelGSS

committed

tools: only report commit validation failure on Slack

PR-URL: #61124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 3a7ed25 commit 7e95edc
Copy full SHA for 7e95edc

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • notify-on-push.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/notify-on-push.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/notify-on-push.yml

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -36,11 +36,12 @@ jobs:
36	36	with:
37	37	persist-credentials: false
38	38	- name: Check commit message
	39	+ id: commit-check
39	40	run: npx -q core-validate-commit "$COMMIT"
40	41	env:
41	42	COMMIT: ${{ github.event.after }}
42	43	- name: Slack Notification
43		- if: failure()
	44	+ if: ${{ failure() && steps.commit-check.conclusion == 'failure' }}
44	45	uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # 2.3.3
45	46	env:
46	47	SLACK_COLOR: '#DE512A'

0 commit comments

Comments

0 (0)