Commit 7eba62e
test: make test-tls-external-accessor agnostic
Remove reliance on V8-specific error messages in
test/parallel/test-tls-external-accessor.js.
Check that the error is a `TypeError`.
The test should now be successful without modification using ChakraCore.
Backport-PR-URL: #20456
PR-URL: #16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 9e68947 commit 7eba62e
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,12 +11,12 @@ const tls = require('tls'); | |||
| 11 | 11 | { | |
| 12 | 12 | const pctx = tls.createSecureContext().context; | |
| 13 | 13 | const cctx = Object.create(pctx); | |
| 14 | - assert.throws(() => cctx._external, /incompatible receiver/); | ||
| 14 | + assert.throws(() => cctx._external, TypeError); | ||
| 15 | 15 | pctx._external; | |
| 16 | 16 | } | |
| 17 | 17 | { | |
| 18 | 18 | const pctx = tls.createSecurePair().credentials.context; | |
| 19 | 19 | const cctx = Object.create(pctx); | |
| 20 | - assert.throws(() => cctx._external, /incompatible receiver/); | ||
| 20 | + assert.throws(() => cctx._external, TypeError); | ||
| 21 | 21 | pctx._external; | |
| 22 | 22 | } | |
0 commit comments