FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: improve control abstraction coverage in frozen intrinsics · nodejs/node@7ee31b0 · GitHub

/ node Public

Commit 7ee31b0

Browse files
Renegade334
authored and
aduh95
committed
lib: improve control abstraction coverage in frozen intrinsics
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #63698 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 0784578 commit 7ee31b0

3 files changed

Lines changed: 52 additions & 26 deletions

File tree

‎lib/internal/freeze_intrinsics.js‎

Lines changed: 37 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ const {
3131
ArrayPrototype,
3232
ArrayPrototypeForEach,
3333
ArrayPrototypePush,
34+
AsyncFunctionPrototype,
35+
AsyncGeneratorFunctionPrototype,
36+
AsyncGeneratorFunctionPrototypePrototype,
3437
AsyncIteratorPrototype,
3538
Atomics,
3639
BigInt,
@@ -57,14 +60,19 @@ const {
5760
Float64ArrayPrototype,
5861
Function,
5962
FunctionPrototype,
63+
GeneratorFunctionPrototype,
64+
GeneratorFunctionPrototypePrototype,
6065
Int16Array,
6166
Int16ArrayPrototype,
6267
Int32Array,
6368
Int32ArrayPrototype,
6469
Int8Array,
6570
Int8ArrayPrototype,
71+
Iterator,
72+
IteratorHelperPrototype,
6673
IteratorPrototype,
6774
Map,
75+
MapIteratorPrototype,
6876
MapPrototype,
6977
Number,
7078
NumberPrototype,
@@ -88,15 +96,15 @@ const {
8896
ReflectOwnKeys,
8997
RegExp,
9098
RegExpPrototype,
99+
RegExpStringIteratorPrototype,
91100
SafeSet,
92101
Set,
102+
SetIteratorPrototype,
93103
SetPrototype,
94104
String,
95105
StringIteratorPrototype,
96106
StringPrototype,
97107
Symbol,
98-
SymbolIterator,
99-
SymbolMatchAll,
100108
SymbolPrototype,
101109
SyntaxError,
102110
SyntaxErrorPrototype,
@@ -120,6 +128,7 @@ const {
120128
WeakRefPrototype,
121129
WeakSet,
122130
WeakSetPrototype,
131+
WrapForValidIteratorPrototype,
123132
decodeURI,
124133
decodeURIComponent,
125134
encodeURI,
@@ -173,8 +182,7 @@ module.exports = function() {
173182
StringPrototype, // 22.1
174183
StringIteratorPrototype, // 22.1.5
175184
RegExpPrototype, // 22.2
176-
// 22.2.7 RegExpStringIteratorPrototype
177-
ObjectGetPrototypeOf(/e/[SymbolMatchAll]()),
185+
RegExpStringIteratorPrototype, // 22.2.9
178186

179187
// 23 Indexed Collections
180188
ArrayPrototype, // 23.1
@@ -195,11 +203,9 @@ module.exports = function() {
195203

196204
// 24 Keyed Collections
197205
MapPrototype, // 24.1
198-
// 24.1.5 MapIteratorPrototype
199-
ObjectGetPrototypeOf(new Map()[SymbolIterator]()),
206+
MapIteratorPrototype, // 24.1.5
200207
SetPrototype, // 24.2
201-
// 24.2.5 SetIteratorPrototype
202-
ObjectGetPrototypeOf(new Set()[SymbolIterator]()),
208+
SetIteratorPrototype, // 24.2.6
203209
WeakMapPrototype, // 24.3
204210
WeakSetPrototype, // 24.4
205211

@@ -212,10 +218,18 @@ module.exports = function() {
212218
FinalizationRegistryPrototype, // 26.2
213219

214220
// 27 Control Abstraction Objects
215-
// 27.1 Iteration
216-
IteratorPrototype, // 27.1.2 IteratorPrototype
217-
AsyncIteratorPrototype, // 27.1.3 AsyncIteratorPrototype
221+
IteratorHelperPrototype, // 27.1.2
222+
IteratorPrototype, // 27.1.3
223+
WrapForValidIteratorPrototype, // 27.1.3.2.2.1
224+
AsyncIteratorPrototype, // 27.1.4
218225
PromisePrototype, // 27.2
226+
GeneratorFunctionPrototype, // 27.3
227+
AsyncGeneratorFunctionPrototype, // 27.4
228+
// 27.5 GeneratorPrototype
229+
GeneratorFunctionPrototypePrototype,
230+
// 27.6 AsyncGeneratorPrototype
231+
AsyncGeneratorFunctionPrototypePrototype,
232+
AsyncFunctionPrototype, // 27.7
219233

220234
// Other APIs / Web Compatibility
221235
Console.prototype,
@@ -268,8 +282,7 @@ module.exports = function() {
268282
String, // 22.1
269283
StringIteratorPrototype, // 22.1.5
270284
RegExp, // 22.2
271-
// 22.2.7 RegExpStringIteratorPrototype
272-
ObjectGetPrototypeOf(/e/[SymbolMatchAll]()),
285+
RegExpStringIteratorPrototype, // 22.2.9
273286

274287
// 23 Indexed Collections
275288
Array, // 23.1
@@ -290,11 +303,9 @@ module.exports = function() {
290303

291304
// 24 Keyed Collections
292305
Map, // 24.1
293-
// 24.1.5 MapIteratorPrototype
294-
ObjectGetPrototypeOf(new Map()[SymbolIterator]()),
306+
MapIteratorPrototype, // 24.1.5
295307
Set, // 24.2
296-
// 24.2.5 SetIteratorPrototype
297-
ObjectGetPrototypeOf(new Set()[SymbolIterator]()),
308+
SetIteratorPrototype, // 24.2.6
298309
WeakMap, // 24.3
299310
WeakSet, // 24.4
300311

@@ -310,19 +321,19 @@ module.exports = function() {
310321
FinalizationRegistry, // 26.2
311322

312323
// 27 Control Abstraction Objects
313-
// 27.1 Iteration
314-
ObjectGetPrototypeOf(ArrayIteratorPrototype), // 27.1.2 IteratorPrototype
315-
// 27.1.3 AsyncIteratorPrototype
316-
ObjectGetPrototypeOf(ObjectGetPrototypeOf(ObjectGetPrototypeOf(
317-
(async function*() {})(),
318-
))),
324+
IteratorHelperPrototype, // 27.1.2
325+
Iterator, // 27.1.3
326+
WrapForValidIteratorPrototype, // 27.1.3.2.2.1
327+
ArrayIteratorPrototype, // 27.1.4
319328
Promise, // 27.2
320329
// 27.3 GeneratorFunction
321-
ObjectGetPrototypeOf(function* () {}),
330+
// 27.5 Generator
331+
GeneratorFunctionPrototype,
322332
// 27.4 AsyncGeneratorFunction
323-
ObjectGetPrototypeOf(async function* () {}),
333+
// 27.6 AsyncGenerator
334+
AsyncGeneratorFunctionPrototype,
324335
// 27.7 AsyncFunction
325-
ObjectGetPrototypeOf(async function() {}),
336+
AsyncFunctionPrototype,
326337

327338
// 28 Reflection
328339
// eslint-disable-next-line node-core/prefer-primordials

‎lib/internal/per_context/primordials.js‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,22 @@ function copyPrototype(src, dest, prefix) {
263263
name: 'ArrayIteratorPrototype',
264264
original: Reflect.getPrototypeOf(Array.prototype[Symbol.iterator]()),
265265
},
266+
{
267+
name: 'AsyncFunctionPrototype',
268+
original: Reflect.getPrototypeOf(async function() {}),
269+
},
270+
{
271+
name: 'AsyncGeneratorFunctionPrototype',
272+
original: Reflect.getPrototypeOf(async function*() {}),
273+
},
266274
{
267275
name: 'AsyncIteratorPrototype',
268276
original: Reflect.getPrototypeOf(Reflect.getPrototypeOf(async function*() {}).prototype),
269277
},
278+
{
279+
name: 'GeneratorFunctionPrototype',
280+
original: Reflect.getPrototypeOf(function*() {}),
281+
},
270282
{
271283
name: 'IteratorHelperPrototype',
272284
original: Reflect.getPrototypeOf(primordials.IteratorPrototypeDrop({ __proto__: null }, null)),

‎typings/primordials.d.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,10 @@ declare namespace primordials {
561561
export const IteratorPrototypeSymbolIterator: UncurryMethod<typeof Iterator.prototype, typeof Symbol.iterator>
562562
export const ArrayIteratorPrototype: ReturnType<typeof Array.prototype[typeof Symbol.iterator]>
563563
export const ArrayIteratorPrototypeNext: UncurryThis<typeof ArrayIteratorPrototype.next>
564+
export const AsyncFunctionPrototype: Function
565+
export const AsyncGeneratorFunctionPrototype: Function
564566
export const AsyncIteratorPrototype: AsyncIterable<any>
567+
export const GeneratorFunctionPrototype: Function
565568
export const IteratorHelperPrototype: ReturnType<typeof Iterator.prototype.drop>
566569
export const MapIteratorPrototype: ReturnType<typeof Map.prototype[typeof Symbol.iterator]>
567570
export const MapIteratorPrototypeNext: UncurryThis<typeof MapIteratorPrototype.next>

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL