Commit 7f5bb9d
console: bind methods from the prototype chain in Console
In 6223236 we made the console.Console function construct an object
with methods from Console.prototype bound to the instance, instead of
with methods found on the prototype chain to be bound on the instances,
thus breaking users overriding these methods when subclassing Console
because they are not expecting this function to construct a
namespace whose methods are not looked up from the prototype
chain.
This patch restores the previous behavior since it does not affect
the characteristics of the global console anyway. So after this patch,
the Console function still constructs normal objects with function
properties looked up from the prototype chain but bound to the
instances always.
PR-URL: #24047
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent b2b0645 commit 7f5bb9d
2 files changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -132,7 +132,10 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) { | |||
| 132 | 132 | var keys = Object.keys(Console.prototype); | |
| 133 | 133 | for (var v = 0; v < keys.length; v++) { | |
| 134 | 134 | var k = keys[v]; | |
| 135 | - this[k] = Console.prototype[k].bind(this); | ||
| 135 | + // We have to bind the methods grabbed from the instance instead of from | ||
| 136 | + // the prototype so that users extending the Console can override them | ||
| 137 | + // from the prototype chain of the subclass. | ||
| 138 | + this[k] = this[k].bind(this); | ||
| 136 | 139 | } | |
| 137 | 140 | } | |
| 138 | 141 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -105,10 +105,16 @@ out.write = err.write = (d) => {}; | |||
| 105 | 105 | { | |
| 106 | 106 | class MyConsole extends Console { | |
| 107 | 107 | hello() {} | |
| 108 | + // See if the methods on Console.prototype are overridable. | ||
| 109 | + log() { return 'overridden'; } | ||
| 108 | 110 | } | |
| 109 | 111 | const myConsole = new MyConsole(process.stdout); | |
| 110 | 112 | assert.strictEqual(typeof myConsole.hello, 'function'); | |
| 111 | 113 | assert.ok(myConsole instanceof Console); | |
| 114 | + assert.strictEqual(myConsole.log(), 'overridden'); | ||
| 115 | + | ||
| 116 | + const log = myConsole.log; | ||
| 117 | + assert.strictEqual(log(), 'overridden'); | ||
| 112 | 118 | } | |
| 113 | 119 | ||
| 114 | 120 | // Instance that does not ignore the stream errors. | |
0 commit comments