Commit 7f85a2c
assert,util: improve deep equal comparison performance
This is mainly a performance improvement for a lot of simple cases.
Diverging elements are detected earlier and equal entries are
partially also detected faster.
A small correctness patch is also included where recursions now
stop as soon as either side has a circular structure. Before, both
sides had to have a circular structure at the specific comparison
which could have caused more checks that likely fail at a later
point.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #46593
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent abba45e commit 7f85a2c
4 files changed
Lines changed: 175 additions & 132 deletions
File tree
- benchmark/assert
- doc/api
- lib/internal/util
- test/parallel
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12,7 +12,8 @@ const bench = common.createBenchmark(main, { | |||
| 12 | 12 | combinationFilter: (p) => { | |
| 13 | 13 | return p.size === 1e4 && p.n === 25 || | |
| 14 | 14 | p.size === 1e3 && p.n === 2e2 || | |
| 15 | - p.size === 1e2 && p.n === 2e3; | ||
| 15 | + p.size === 1e2 && p.n === 2e3 || | ||
| 16 | + p.size === 1; | ||
| 16 | 17 | }, | |
| 17 | 18 | }); | |
| 18 | 19 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -546,6 +546,10 @@ An alias of [`assert.ok()`][]. | |||
| 546 | 546 | <!-- YAML | |
| 547 | 547 | added: v0.1.21 | |
| 548 | 548 | changes: | |
| 549 | + - version: REPLACEME | ||
| 550 | + pr-url: https://github.com/nodejs/node/pull/46593 | ||
| 551 | + description: Recursion now stops when either side encounters a circular | ||
| 552 | + reference. | ||
| 549 | 553 | - version: v18.0.0 | |
| 550 | 554 | pr-url: https://github.com/nodejs/node/pull/41020 | |
| 551 | 555 | description: Regular expressions lastIndex property is now compared as well. | |
@@ -617,7 +621,7 @@ are also recursively evaluated by the following rules. | |||
| 617 | 621 | * [Object wrappers][] are compared both as objects and unwrapped values. | |
| 618 | 622 | * `Object` properties are compared unordered. | |
| 619 | 623 | * [`Map`][] keys and [`Set`][] items are compared unordered. | |
| 620 | - * Recursion stops when both sides differ or both sides encounter a circular | ||
| 624 | + * Recursion stops when both sides differ or either side encounters a circular | ||
| 621 | 625 | reference. | |
| 622 | 626 | * Implementation does not test the [`[[Prototype]]`][prototype-spec] of | |
| 623 | 627 | objects. | |
@@ -727,6 +731,10 @@ parameter is an instance of an [`Error`][] then it will be thrown instead of the | |||
| 727 | 731 | <!-- YAML | |
| 728 | 732 | added: v1.2.0 | |
| 729 | 733 | changes: | |
| 734 | + - version: REPLACEME | ||
| 735 | + pr-url: https://github.com/nodejs/node/pull/46593 | ||
| 736 | + description: Recursion now stops when either side encounters a circular | ||
| 737 | + reference. | ||
| 730 | 738 | - version: v18.0.0 | |
| 731 | 739 | pr-url: https://github.com/nodejs/node/pull/41020 | |
| 732 | 740 | description: Regular expressions lastIndex property is now compared as well. | |
@@ -780,7 +788,7 @@ are recursively evaluated also by the following rules. | |||
| 780 | 788 | * [Object wrappers][] are compared both as objects and unwrapped values. | |
| 781 | 789 | * `Object` properties are compared unordered. | |
| 782 | 790 | * [`Map`][] keys and [`Set`][] items are compared unordered. | |
| 783 | - * Recursion stops when both sides differ or both sides encounter a circular | ||
| 791 | + * Recursion stops when both sides differ or either side encounters a circular | ||
| 784 | 792 | reference. | |
| 785 | 793 | * [`WeakMap`][] and [`WeakSet`][] comparison does not rely on their values. See | |
| 786 | 794 | below for further details. | |
0 commit comments