Commit 7fa5f54
src: remove trace_sync_io_ from env
This commit removes trace_sync_io_ and instead uses the options value
directly.
PR-URL: #22726
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>1 parent 649288b commit 7fa5f54
4 files changed
Lines changed: 2 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -416,7 +416,7 @@ inline void Environment::set_printed_error(bool value) { | |||
| 416 | 416 | } | |
| 417 | 417 | ||
| 418 | 418 | inline void Environment::set_trace_sync_io(bool value) { | |
| 419 | - trace_sync_io_ = value; | ||
| 419 | + options_->trace_sync_io = value; | ||
| 420 | 420 | } | |
| 421 | 421 | ||
| 422 | 422 | inline bool Environment::abort_on_uncaught_exception() const { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -113,7 +113,6 @@ Environment::Environment(IsolateData* isolate_data, | |||
| 113 | 113 | tick_info_(context->GetIsolate()), | |
| 114 | 114 | timer_base_(uv_now(isolate_data->event_loop())), | |
| 115 | 115 | printed_error_(false), | |
| 116 | - trace_sync_io_(false), | ||
| 117 | 116 | abort_on_uncaught_exception_(false), | |
| 118 | 117 | emit_env_nonstring_warning_(true), | |
| 119 | 118 | makecallback_cntr_(0), | |
@@ -309,7 +308,7 @@ void Environment::StopProfilerIdleNotifier() { | |||
| 309 | 308 | } | |
| 310 | 309 | ||
| 311 | 310 | void Environment::PrintSyncTrace() const { | |
| 312 | - if (!trace_sync_io_) | ||
| 311 | + if (!options_->trace_sync_io) | ||
| 313 | 312 | return; | |
| 314 | 313 | ||
| 315 | 314 | HandleScope handle_scope(isolate()); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -888,7 +888,6 @@ class Environment { | |||
| 888 | 888 | TickInfo tick_info_; | |
| 889 | 889 | const uint64_t timer_base_; | |
| 890 | 890 | bool printed_error_; | |
| 891 | - bool trace_sync_io_; | ||
| 892 | 891 | bool abort_on_uncaught_exception_; | |
| 893 | 892 | bool emit_env_nonstring_warning_; | |
| 894 | 893 | size_t makecallback_cntr_; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3054,8 +3054,6 @@ inline int Start(Isolate* isolate, IsolateData* isolate_data, | |||
| 3054 | 3054 | env.async_hooks()->pop_async_id(1); | |
| 3055 | 3055 | } | |
| 3056 | 3056 | ||
| 3057 | - env.set_trace_sync_io(env.options()->trace_sync_io); | ||
| 3058 | - | ||
| 3059 | 3057 | { | |
| 3060 | 3058 | SealHandleScope seal(isolate); | |
| 3061 | 3059 | bool more; | |
0 commit comments