Commit 7fb4794
test: increase RAM requirement for intensive tests
test-fs-read-buffer-tostring-fail and test-fs-readfile-tostring-fail
have been timing out on Raspberry Pi 3 devices on the continuous
integration server. These devices have 1 Gb of RAM and the tests are
memory intensive. Previous checks for memory intensive tests used a 512
Mb cut-off, but that was probably instituted when we only had Pi 1
devices.
Consequently, this change increases the threshold for memory-intensive
tests to 1 Gb and adds that threshold to test-fs-readfile-tostring-fail.
PR-URL: #7772
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 4839ef3 commit 7fb4794
2 files changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,7 +27,7 @@ exports.isLinuxPPCBE = (process.platform === 'linux') && | |||
| 27 | 27 | exports.isSunOS = process.platform === 'sunos'; | |
| 28 | 28 | exports.isFreeBSD = process.platform === 'freebsd'; | |
| 29 | 29 | ||
| 30 | - exports.enoughTestMem = os.totalmem() > 0x20000000; /* 512MB */ | ||
| 30 | + exports.enoughTestMem = os.totalmem() > 0x40000000; /* 1 Gb */ | ||
| 31 | 31 | exports.rootDir = exports.isWindows ? 'c:\\' : '/'; | |
| 32 | 32 | ||
| 33 | 33 | function rimrafSync(p) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,6 +1,13 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | ||
| 3 | 3 | const common = require('../common'); | |
| 4 | + | ||
| 5 | + if (!common.enoughTestMem) { | ||
| 6 | + const skipMessage = 'intensive toString tests due to memory confinements'; | ||
| 7 | + common.skip(skipMessage); | ||
| 8 | + return; | ||
| 9 | + } | ||
| 10 | + | ||
| 4 | 11 | const assert = require('assert'); | |
| 5 | 12 | const fs = require('fs'); | |
| 6 | 13 | const path = require('path'); | |
0 commit comments