Commit 804b398
Myles Borins
deps: revert botched V8 backport
Original Commit Message:
"build: cherry pick V8 change for windows DLL support"
This reverts commit 92ecbc4.
The original commit did not include the entire changeset
PR-URL: #9610
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>1 parent a8840bb commit 804b398
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,6 @@ | |||
| 39 | 39 | 'ubsan_vptr%': 0, | |
| 40 | 40 | 'v8_target_arch%': '<(target_arch)', | |
| 41 | 41 | 'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")', | |
| 42 | - 'force_dynamic_crt%': 0, | ||
| 43 | 42 | # Native Client builds currently use the V8 ARM JIT and | |
| 44 | 43 | # arm/simulator-arm.cc to defer the significant effort required | |
| 45 | 44 | # for NaCl JIT support. The nacl_target_arch variable provides | |
@@ -1105,7 +1104,7 @@ | |||
| 1105 | 1104 | 'VCCLCompilerTool': { | |
| 1106 | 1105 | 'Optimization': '0', | |
| 1107 | 1106 | 'conditions': [ | |
| 1108 | - ['component=="shared_library" or force_dynamic_crt==1', { | ||
| 1107 | + ['component=="shared_library"', { | ||
| 1109 | 1108 | 'RuntimeLibrary': '3', # /MDd | |
| 1110 | 1109 | }, { | |
| 1111 | 1110 | 'RuntimeLibrary': '1', # /MTd | |
@@ -1157,7 +1156,7 @@ | |||
| 1157 | 1156 | 'StringPooling': 'true', | |
| 1158 | 1157 | 'BasicRuntimeChecks': '0', | |
| 1159 | 1158 | 'conditions': [ | |
| 1160 | - ['component=="shared_library" or force_dynamic_crt==1', { | ||
| 1159 | + ['component=="shared_library"', { | ||
| 1161 | 1160 | 'RuntimeLibrary': '3', #/MDd | |
| 1162 | 1161 | }, { | |
| 1163 | 1162 | 'RuntimeLibrary': '1', #/MTd | |
@@ -1348,7 +1347,7 @@ | |||
| 1348 | 1347 | 'FavorSizeOrSpeed': '0', | |
| 1349 | 1348 | 'StringPooling': 'true', | |
| 1350 | 1349 | 'conditions': [ | |
| 1351 | - ['component=="shared_library" or force_dynamic_crt==1', { | ||
| 1350 | + ['component=="shared_library"', { | ||
| 1352 | 1351 | 'RuntimeLibrary': '2', #/MD | |
| 1353 | 1352 | }, { | |
| 1354 | 1353 | 'RuntimeLibrary': '0', #/MT | |
0 commit comments