Commit 804d880
permission: fix data types in PrintTree
* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
reference type to avoid copying the object.
Refs: #48677
PR-URL: #48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent c8da8c8 commit 804d880
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -73,7 +73,7 @@ namespace node { | |||
| 73 | 73 | ||
| 74 | 74 | namespace permission { | |
| 75 | 75 | ||
| 76 | - void PrintTree(FSPermission::RadixTree::Node* node, int spaces = 0) { | ||
| 76 | + void PrintTree(const FSPermission::RadixTree::Node* node, size_t spaces = 0) { | ||
| 77 | 77 | std::string whitespace(spaces, ' '); | |
| 78 | 78 | ||
| 79 | 79 | if (node == nullptr) { | |
@@ -90,8 +90,8 @@ void PrintTree(FSPermission::RadixTree::Node* node, int spaces = 0) { | |||
| 90 | 90 | whitespace, | |
| 91 | 91 | node->prefix); | |
| 92 | 92 | if (node->children.size()) { | |
| 93 | - int child = 0; | ||
| 94 | - for (const auto pair : node->children) { | ||
| 93 | + size_t child = 0; | ||
| 94 | + for (const auto& pair : node->children) { | ||
| 95 | 95 | ++child; | |
| 96 | 96 | per_process::Debug(DebugCategory::PERMISSION_MODEL, | |
| 97 | 97 | "%s Child(%s): %s\n", | |
0 commit comments