Commit 806bc0d
test: fix assert.throws error in test-http-parser
The third argument of `assert.throws()` is a message that is used by the
AssertionError, not the message to check in the thrown error. It appears
that there is an assert.throws() in test-http-parser that expects the
latter behavior. Rewrite the call to check the error message. Even if
this wasn't a mistake, this change results in a more robust check.
PR-URL: #19626
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 2f09ee7 commit 806bc0d
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -97,9 +97,10 @@ function expectBody(expected) { | |||
| 97 | 97 | ||
| 98 | 98 | parser.reinitialize(HTTPParser.REQUEST); | |
| 99 | 99 | ||
| 100 | - assert.throws(function() { | ||
| 101 | - parser.execute(request, 0, request.length); | ||
| 102 | - }, Error, 'hello world'); | ||
| 100 | + assert.throws( | ||
| 101 | + () => { parser.execute(request, 0, request.length); }, | ||
| 102 | + { name: 'Error', message: 'hello world' } | ||
| 103 | + ); | ||
| 103 | 104 | } | |
| 104 | 105 | ||
| 105 | 106 | ||
0 commit comments