module: require.resolve.paths returns null with node schema · nodejs/node@809371a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 809371a

Browse filesBrowse the repository at this point in the historyBrowse files

fossamagna

authored and

BethGriggs

committed

module: require.resolve.paths returns null with node schema

require.resolve.paths should returns null with builtin module. when builtin module without `node:` schema, `paths` returns null. But, it don't return null when builtin module with `node:` schema. Fixes: #45001 PR-URL: #45147 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

1 parent efe1be4 commit 809371a
Copy full SHA for 809371a

2 files changed

+11-2Lines changed: 11 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/modules/cjs
  • loader.js
• test/parallel
  • test-require-resolve.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/modules/cjs/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/loader.js

+7-2Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -737,8 +737,13 @@ if (isWindows) {
737	737	}
738	738
739	739	Module._resolveLookupPaths = function(request, parent) {
740		- if (BuiltinModule.canBeRequiredByUsers(request) &&
741		- BuiltinModule.canBeRequiredWithoutScheme(request)) {
	740	+ if ((
	741	+ StringPrototypeStartsWith(request, 'node:') &&
	742	+ BuiltinModule.canBeRequiredByUsers(StringPrototypeSlice(request, 5))
	743	+ ) || (
	744	+ BuiltinModule.canBeRequiredByUsers(request) &&
	745	+ BuiltinModule.canBeRequiredWithoutScheme(request)
	746	+ )) {
742	747	debug('looking for %j in []', request);
743	748	return null;
744	749	}

Collapse file

‎test/parallel/test-require-resolve.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-require-resolve.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -63,6 +63,10 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js'));
63	63	assert.strictEqual(require.resolve.paths(mod), null);
64	64	});
65	65
	66	+ builtinModules.forEach((mod) => {
	67	+ assert.strictEqual(require.resolve.paths(`node:${mod}`), null);
	68	+ });
	69	+
66	70	// node_modules.
67	71	const resolvedPaths = require.resolve.paths('eslint');
68	72	assert.strictEqual(Array.isArray(resolvedPaths), true);

0 commit comments

Comments

0 (0)