Commit 80a3766
build: use list for mutable retval rather than tuple
We define `retval` as a tuple and then replace the tuple by "appending"
items with `+=` but that actually creates a new tuple every time.
Because it is intended to be mutable, use a list instead, then return a
tuple from the function, as it should be immutable outside the function.
PR-URL: #41372
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 0768302 commit 80a3766
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -828,7 +828,7 @@ def pkg_config(pkg): | |||
| 828 | 828 | otherwise (None, None, None, None)""" | |
| 829 | 829 | pkg_config = os.environ.get('PKG_CONFIG', 'pkg-config') | |
| 830 | 830 | args = [] # Print pkg-config warnings on first round. | |
| 831 | - retval = () | ||
| 831 | + retval = [] | ||
| 832 | 832 | for flag in ['--libs-only-l', '--cflags-only-I', | |
| 833 | 833 | '--libs-only-L', '--modversion']: | |
| 834 | 834 | args += [flag] | |
@@ -843,9 +843,9 @@ def pkg_config(pkg): | |||
| 843 | 843 | except OSError as e: | |
| 844 | 844 | if e.errno != errno.ENOENT: raise e # Unexpected error. | |
| 845 | 845 | return (None, None, None, None) # No pkg-config/pkgconf installed. | |
| 846 | - retval += (val,) | ||
| 846 | + retval.append(val) | ||
| 847 | 847 | args = ['--silence-errors'] | |
| 848 | - return retval | ||
| 848 | + return tuple(retval) | ||
| 849 | 849 | ||
| 850 | 850 | ||
| 851 | 851 | def try_check_compiler(cc, lang): | |
0 commit comments