Commit 817befd
deps: V8: backport bb9f0c2b2fe9
Original commit message:
[snapshot] Improve snapshot docs and error printing
- Minor improvements to the documentation for snapshotting.
- Add newlines to printed errors where necessary.
Change-Id: I822e7e850adb67eae73b51c23cf34e40ba3106f0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144954
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67111}
Refs: v8/v8@bb9f0c2
PR-URL: #33300
Refs: v8/v8@ea0719b
Refs: v8/v8@22014de
Refs: #17058
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 8f82692 commit 817befd
4 files changed
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.18', | ||
| 39 | + 'v8_embedder_string': '-node.19', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9804,6 +9804,11 @@ class V8_EXPORT V8 { | |||
| 9804 | 9804 | ||
| 9805 | 9805 | /** | |
| 9806 | 9806 | * Helper class to create a snapshot data blob. | |
| 9807 | + * | ||
| 9808 | + * The Isolate used by a SnapshotCreator is owned by it, and will be entered | ||
| 9809 | + * and exited by the constructor and destructor, respectively; The destructor | ||
| 9810 | + * will also destroy the Isolate. Experimental language features, including | ||
| 9811 | + * those available by default, are not available while creating a snapshot. | ||
| 9807 | 9812 | */ | |
| 9808 | 9813 | class V8_EXPORT SnapshotCreator { | |
| 9809 | 9814 | public: | |
@@ -9832,6 +9837,10 @@ class V8_EXPORT SnapshotCreator { | |||
| 9832 | 9837 | SnapshotCreator(const intptr_t* external_references = nullptr, | |
| 9833 | 9838 | StartupData* existing_blob = nullptr); | |
| 9834 | 9839 | ||
| 9840 | + /** | ||
| 9841 | + * Destroy the snapshot creator, and exit and dispose of the Isolate | ||
| 9842 | + * associated with it. | ||
| 9843 | + */ | ||
| 9835 | 9844 | ~SnapshotCreator(); | |
| 9836 | 9845 | ||
| 9837 | 9846 | /** | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -76,7 +76,8 @@ ExternalReferenceEncoder::Value ExternalReferenceEncoder::Encode( | |||
| 76 | 76 | if (maybe_index.IsNothing()) { | |
| 77 | 77 | void* addr = reinterpret_cast<void*>(address); | |
| 78 | 78 | v8::base::OS::PrintError("Unknown external reference %p.\n", addr); | |
| 79 | - v8::base::OS::PrintError("%s", ExternalReferenceTable::ResolveSymbol(addr)); | ||
| 79 | + v8::base::OS::PrintError("%s\n", | ||
| 80 | + ExternalReferenceTable::ResolveSymbol(addr)); | ||
| 80 | 81 | v8::base::OS::Abort(); | |
| 81 | 82 | } | |
| 82 | 83 | Value result(maybe_index.FromJust()); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -193,6 +193,7 @@ void SerializedHandleChecker::VisitRootPointers(Root root, | |||
| 193 | 193 | PrintF("%s handle not serialized: ", | |
| 194 | 194 | root == Root::kGlobalHandles ? "global" : "eternal"); | |
| 195 | 195 | (*p).Print(); | |
| 196 | + PrintF("\n"); | ||
| 196 | 197 | ok_ = false; | |
| 197 | 198 | } | |
| 198 | 199 | } | |
0 commit comments