test: remove unnecessary default tmpdir value in test · nodejs/node@818b280 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 818b280

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

rvagg

committed

test: remove unnecessary default tmpdir value in test

`tmpdir.path` will never be falsy so there is no need to guard against that. PR-URL: #26177 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>

1 parent 823f0ce commit 818b280
Copy full SHA for 818b280

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-pipe-file-to-http.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-pipe-file-to-http.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-pipe-file-to-http.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -29,7 +29,7 @@ const path = require('path');
29	29	const tmpdir = require('../common/tmpdir');
30	30	tmpdir.refresh();
31	31
32		- const filename = path.join(tmpdir.path || '/tmp', 'big');
	32	+ const filename = path.join(tmpdir.path, 'big');
33	33	let count = 0;
34	34
35	35	const server = http.createServer((req, res) => {

0 commit comments

Comments

0 (0)