Commit 8195c81
src: avoid copying BaseObjectPtrs in loop
While copying BaseObjectPtrs is cheap, it is not a no-op, so it is best
to iterate over references to BaseObjectPtrs only.
PR-URL: #44270
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent fdb699c commit 8195c81
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -349,7 +349,7 @@ class SerializerDelegate : public ValueSerializer::Delegate { | |||
| 349 | 349 | std::vector<BaseObjectPtr<BaseObject>> nested_transferables; | |
| 350 | 350 | if (!host_objects_[i]->NestedTransferables().To(&nested_transferables)) | |
| 351 | 351 | return Nothing<bool>(); | |
| 352 | - for (auto nested_transferable : nested_transferables) { | ||
| 352 | + for (auto& nested_transferable : nested_transferables) { | ||
| 353 | 353 | if (std::find(host_objects_.begin(), | |
| 354 | 354 | host_objects_.end(), | |
| 355 | 355 | nested_transferable) == host_objects_.end()) { | |
0 commit comments