Commit 81e603b
test: specify global object for globals
Be explicit about using `global.externalizeString()` etc. in
test-fs-write instead of disabling the `no-undef` ESLint rule.
PR-URL: #36498
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c3ec90d commit 81e603b
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,8 +36,10 @@ const fn4 = path.join(tmpdir.path, 'write4.txt'); | |||
| 36 | 36 | const expected = 'ümlaut.'; | |
| 37 | 37 | const constants = fs.constants; | |
| 38 | 38 | ||
| 39 | - /* eslint-disable no-undef */ | ||
| 40 | - common.allowGlobals(externalizeString, isOneByteString, x); | ||
| 39 | + const { externalizeString, isOneByteString } = global; | ||
| 40 | + | ||
| 41 | + // Account for extra globals exposed by --expose_externalize_string. | ||
| 42 | + common.allowGlobals(externalizeString, isOneByteString, global.x); | ||
| 41 | 43 | ||
| 42 | 44 | { | |
| 43 | 45 | const expected = 'ümlaut sechzig'; // Must be a unique string. | |
@@ -78,7 +80,6 @@ common.allowGlobals(externalizeString, isOneByteString, x); | |||
| 78 | 80 | fs.closeSync(fd); | |
| 79 | 81 | assert.strictEqual(fs.readFileSync(fn, 'utf8'), expected); | |
| 80 | 82 | } | |
| 81 | - /* eslint-enable no-undef */ | ||
| 82 | 83 | ||
| 83 | 84 | fs.open(fn, 'w', 0o644, common.mustSucceed((fd) => { | |
| 84 | 85 | const done = common.mustSucceed((written) => { | |
0 commit comments