src: remove unnecessary static qualifier in crypto_dh.cc · nodejs/node@81ef4cc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 81ef4cc

Browse filesBrowse the repository at this point in the historyBrowse files

RaisinTen

authored and

juanarbol

committed

src: remove unnecessary static qualifier in crypto_dh.cc

ZeroPadDiffieHellmanSecret() is in an anonymous namespace, so it has static linkage already. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42492 Refs: #39941 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 6ee9587 commit 81ef4cc
Copy full SHA for 81ef4cc

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/crypto
  • crypto_dh.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/crypto/crypto_dh.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_dh.cc

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -35,9 +35,9 @@ using v8::Value;
35	35
36	36	namespace crypto {
37	37	namespace {
38		- static void ZeroPadDiffieHellmanSecret(size_t remainder_size,
39		- char* data,
40		- size_t length) {
	38	+ void ZeroPadDiffieHellmanSecret(size_t remainder_size,
	39	+ char* data,
	40	+ size_t length) {
41	41	// DH_size returns number of bytes in a prime number.
42	42	// DH_compute_key returns number of bytes in a remainder of exponent, which
43	43	// may have less bytes than a prime number. Therefore add 0-padding to the

0 commit comments

Comments

0 (0)