src: register external references of PipeWrap for snapshot · nodejs/node@826eee3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 826eee3

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

BethGriggs

committed

src: register external references of PipeWrap for snapshot

PR-URL: #39961 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent 7a17cbf commit 826eee3
Copy full SHA for 826eee3

3 files changed

+18-1Lines changed: 18 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_external_reference.h
  • pipe_wrap.cc
  • pipe_wrap.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_external_reference.h‎

Copy file name to clipboardExpand all lines: src/node_external_reference.h

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -71,6 +71,7 @@ class ExternalReferenceRegistry {
71	71	V(tty_wrap) \
72	72	V(url) \
73	73	V(util) \
	74	+ V(pipe_wrap) \
74	75	V(serdes) \
75	76	V(string_decoder) \
76	77	V(stream_wrap) \

Collapse file

‎src/pipe_wrap.cc‎

Copy file name to clipboardExpand all lines: src/pipe_wrap.cc

+15-1Lines changed: 15 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -22,12 +22,13 @@
22	22	#include "pipe_wrap.h"
23	23
24	24	#include "async_wrap.h"
	25	+ #include "connect_wrap.h"
25	26	#include "connection_wrap.h"
26	27	#include "env-inl.h"
27	28	#include "handle_wrap.h"
28	29	#include "node.h"
29	30	#include "node_buffer.h"
30		- #include "connect_wrap.h"
	31	+ #include "node_external_reference.h"
31	32	#include "stream_base-inl.h"
32	33	#include "stream_wrap.h"
33	34	#include "util-inl.h"
@@ -104,6 +105,17 @@ void PipeWrap::Initialize(Local<Object> target,
104	105	constants).Check();
105	106	}
106	107
	108	+ void PipeWrap::RegisterExternalReferences(ExternalReferenceRegistry* registry) {
	109	+ registry->Register(New);
	110	+ registry->Register(Bind);
	111	+ registry->Register(Listen);
	112	+ registry->Register(Connect);
	113	+ registry->Register(Open);
	114	+ #ifdef _WIN32
	115	+ registry->Register(SetPendingInstances);
	116	+ #endif
	117	+ registry->Register(Fchmod);
	118	+ }
107	119
108	120	void PipeWrap::New(const FunctionCallbackInfo<Value>& args) {
109	121	// This constructor should not be exposed to public javascript.
@@ -236,3 +248,5 @@ void PipeWrap::Connect(const FunctionCallbackInfo<Value>& args) {
236	248	} // namespace node
237	249
238	250	NODE_MODULE_CONTEXT_AWARE_INTERNAL(pipe_wrap, node::PipeWrap::Initialize)
	251	+ NODE_MODULE_EXTERNAL_REFERENCE(pipe_wrap,
	252	+ node::PipeWrap::RegisterExternalReferences)

Collapse file

‎src/pipe_wrap.h‎

Copy file name to clipboardExpand all lines: src/pipe_wrap.h

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -29,6 +29,7 @@
29	29
30	30	namespace node {
31	31
	32	+ class ExternalReferenceRegistry;
32	33	class Environment;
33	34
34	35	class PipeWrap : public ConnectionWrap<PipeWrap, uv_pipe_t> {
@@ -47,6 +48,7 @@ class PipeWrap : public ConnectionWrap<PipeWrap, uv_pipe_t> {
47	48	v8::Local<v8::Context> context,
48	49	void* priv);
49	50
	51	+ static void RegisterExternalReferences(ExternalReferenceRegistry* registry);
50	52	SET_NO_MEMORY_INFO()
51	53	SET_MEMORY_INFO_NAME(PipeWrap)
52	54	SET_SELF_SIZE(PipeWrap)

0 commit comments

Comments

0 (0)