Commit 83023e5
test: skip tests that cause timeouts on IBM i
I missed marking a couple of test cases flaky in my previous PR:
#58583
tests missed were:
- parallel.test-inspector-network-content-type
- benchmark.test-benchmark-websocket
After marking the above flaky I re-ran a test build and noticed
the build still failed.
Unfortuantely the build still fails because the build detects that
node process are left behind after the tests, presumably because tests
that spawn child processes are being timed out and only the parent
process is killed off, leaving the child processes behind.
see: #59014 (comment)
We've decided to skip these tests until the underlying issue is
resolved.
The tests being skipped are:
- parallel.test-http-proxy-fetch
- parallel.test-https-proxy-fetch
- benchmark.test-benchmark-websocket
- parallel.test-inspector-network-fetch
- parallel.test-inspector-network-content-type
- es-module.test-wasm-web-api
- parallel.test-fetch
- parallel.test-without-async-context-frame
- report.test-report-exclude-network
PR-URL: #59014
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 4ffa756 commit 83023e5
4 files changed
Lines changed: 10 additions & 7 deletions
File tree
- test
- benchmark
- es-module
- parallel
- report
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,3 +23,5 @@ test-benchmark-crypto: PASS, FLAKY | |||
| 23 | 23 | ||
| 24 | 24 | [$arch==arm] | |
| 25 | 25 | ||
| 26 | + [$system==ibmi] | ||
| 27 | + test-benchmark-websocket: SKIP | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,4 +16,4 @@ test-wasm-web-api: SKIP | |||
| 16 | 16 | ||
| 17 | 17 | [$system==ibmi] | |
| 18 | 18 | # https://github.com/nodejs/node/issues/58582 | |
| 19 | - test-wasm-web-api: PASS,FLAKY | ||
| 19 | + test-wasm-web-api: SKIP | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -129,11 +129,12 @@ test-tls-write-error: PASS, FLAKY | |||
| 129 | 129 | # https://github.com/nodejs/node/issues/48047 | |
| 130 | 130 | test-http-pipeline-flood: SKIP | |
| 131 | 131 | # https://github.com/nodejs/node/issues/58582 | |
| 132 | - test-http-proxy-fetch: PASS, FLAKY | ||
| 133 | - test-https-proxy-fetch: PASS, FLAKY | ||
| 134 | - test-inspector-network-fetch: PASS, FLAKY | ||
| 135 | - test-fetch: PASS, FLAKY | ||
| 136 | - test-without-async-context-frame: PASS, FLAKY | ||
| 132 | + test-http-proxy-fetch: SKIP | ||
| 133 | + test-https-proxy-fetch: SKIP | ||
| 134 | + test-inspector-network-fetch: SKIP | ||
| 135 | + test-inspector-network-content-type: SKIP | ||
| 136 | + test-fetch: SKIP | ||
| 137 | + test-without-async-context-frame: SKIP | ||
| 137 | 138 | test-process-cpuUsage: PASS, FLAKY | |
| 138 | 139 | ||
| 139 | 140 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12,4 +12,4 @@ test-report-fatal-error: PASS, FLAKY | |||
| 12 | 12 | ||
| 13 | 13 | [$system==ibmi] | |
| 14 | 14 | # https://github.com/nodejs/node/issues/58582 | |
| 15 | - test-report-exclude-network: PASS,FLAKY | ||
| 15 | + test-report-exclude-network: SKIP | ||
0 commit comments