FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: put common lint exceptions into config file · nodejs/node@831f266 · GitHub

/ node Public

Commit 831f266

Browse files
Trott
authored and
targos
committed
test: put common lint exceptions into config file
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: #39358 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 0b1ce72 commit 831f266

23 files changed

Lines changed: 3 additions & 27 deletions

‎test/common/.eslintrc.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
rules:
2+
node-core/required-modules: off
3+
node-core/require-common-first: off

‎test/common/arraystream.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const { Stream } = require('stream');

‎test/common/benchmark.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
const assert = require('assert');

‎test/common/countdown.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
const assert = require('assert');

‎test/common/cpu-prof.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
require('./');

‎test/common/dns.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const assert = require('assert');

‎test/common/duplexpair.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const { Duplex } = require('stream');
43
const assert = require('assert');

‎test/common/fixtures.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const path = require('path');

‎test/common/fixtures.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
import fixtures from './fixtures.js';
32

43
const {

‎test/common/heap.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const assert = require('assert');
43
const util = require('util');

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL