Commit 8339d9b
deps: V8: cherry-pick f915fa4c9f41
Original commit message:
[osr] Ensure trying to osr does not skip loop interrupts
Fixed: 374013413
Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
Auto-Submit: Olivier Flückiger <olivf@chromium.org>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#96708}
Refs: v8/v8@f915fa4
PR-URL: #55484
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 4c5555d commit 8339d9b
3 files changed
Lines changed: 24 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.25', | ||
| 41 | + 'v8_embedder_string': '-node.26', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1348,7 +1348,14 @@ MaybeHandle<Code> GetOrCompileOptimized( | |||
| 1348 | 1348 | } | |
| 1349 | 1349 | ||
| 1350 | 1350 | // Do not optimize when debugger needs to hook into every call. | |
| 1351 | - if (isolate->debug()->needs_check_on_function_call()) return {}; | ||
| 1351 | + if (isolate->debug()->needs_check_on_function_call()) { | ||
| 1352 | + // Reset the OSR urgency to avoid triggering this compilation request on | ||
| 1353 | + // every iteration and thereby skipping other interrupts. | ||
| 1354 | + if (IsOSR(osr_offset)) { | ||
| 1355 | + function->feedback_vector()->reset_osr_urgency(); | ||
| 1356 | + } | ||
| 1357 | + return {}; | ||
| 1358 | + } | ||
| 1352 | 1359 | ||
| 1353 | 1360 | // Do not optimize if we need to be able to set break points. | |
| 1354 | 1361 | if (shared->HasBreakInfo(isolate)) return {}; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,15 @@ | |||
| 1 | + // Copyright 2024 the V8 project authors. All rights reserved. | ||
| 2 | + // Use of this source code is governed by a BSD-style license that can be | ||
| 3 | + // found in the LICENSE file. | ||
| 4 | + | ||
| 5 | + // Flags: --enable-inspector | ||
| 6 | + | ||
| 7 | + var Debug = debug.Debug; | ||
| 8 | + Debug.sendMessageForMethodChecked('Runtime.enable', {}); | ||
| 9 | + const {msgid, msg} = Debug.createMessage('Runtime.evaluate', { | ||
| 10 | + expression: 'while(true) {}', | ||
| 11 | + throwOnSideEffect: true, | ||
| 12 | + timeout: 1000, | ||
| 13 | + }) | ||
| 14 | + Debug.sendMessage(msg); | ||
| 15 | + Debug.takeReplyChecked(msgid).toString(); | ||
0 commit comments