test: permit test-graph.signal to work without test runner · nodejs/node@8346596 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8346596

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

test: permit test-graph.signal to work without test runner

test/async-hooks/test-graph.signal.js passes with the test.py test runner but fails if run directly with the `node` executable. Modify the test so it passes in both cases. PR-URL: #28305 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 53297e6 commit 8346596
Copy full SHA for 8346596

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/async-hooks
  • test-graph.signal.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/async-hooks/test-graph.signal.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-graph.signal.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -53,7 +53,11 @@ function onexit() {
53	53	{ type: 'PIPEWRAP', id: 'pipe:4', triggerAsyncId: 'signal:1' },
54	54	{ type: 'PIPEWRAP', id: 'pipe:5', triggerAsyncId: 'signal:1' },
55	55	{ type: 'PIPEWRAP', id: 'pipe:6', triggerAsyncId: 'signal:1' },
56		- { type: 'SIGNALWRAP', id: 'signal:2', triggerAsyncId: 'signal:1' },
	56	+ { type: 'SIGNALWRAP', id: 'signal:2',
	57	+ // TEST_THREAD_ID is set by tools/test.py. Adjust test results depending
	58	+ // on whether the test was invoked via test.py or from the shell
	59	+ // directly.
	60	+ triggerAsyncId: process.env.TEST_THREAD_ID ? 'signal:1' : 'pipe:2' },
57	61	{ type: 'PROCESSWRAP', id: 'process:3', triggerAsyncId: 'signal:1' },
58	62	{ type: 'PIPEWRAP', id: 'pipe:7', triggerAsyncId: 'signal:1' },
59	63	{ type: 'PIPEWRAP', id: 'pipe:8', triggerAsyncId: 'signal:1' },

0 commit comments

Comments

0 (0)