test_runner: filter execArgv fallback for child tests · nodejs/node@83b91ea · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 83b91ea

Browse filesBrowse the repository at this point in the historyBrowse files

trivikr

authored and

richardlau

committed

test_runner: filter execArgv fallback for child tests

Apply the test runner propagation filter to execArgv entries that are not reported by the options binding. This prevents config-file and test-runner flags from leaking into isolated child tests while still preserving V8 flags. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #64056 Refs: https://github.com/nodejs/reliability/issues?q=%22test-runner-flag-propagation%22 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

1 parent ff9122c commit 83b91ea
Copy full SHA for 83b91ea

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/test_runner
  • runner.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/test_runner/runner.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/runner.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -208,7 +208,7 @@ function getRunArgs(path, { forceExit,
208	208	const nodeOptionsSet = new SafeSet(processNodeOptions);
209	209	const unknownProcessExecArgv = ArrayPrototypeFilter(
210	210	process.execArgv,
211		- (arg) => !nodeOptionsSet.has(arg),
	211	+ (arg, i, arr) => !nodeOptionsSet.has(arg) && filterExecArgv(arg, i, arr),
212	212	);
213	213	ArrayPrototypePushApply(runArgs, unknownProcessExecArgv);
214	214

0 commit comments

Comments

0 (0)