build: remove redundant -fuse-linker-plugin from GCC LTO flags · nodejs/node@8452830 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8452830

Browse filesBrowse the repository at this point in the historyBrowse files

robertsLando

authored and

aduh95

committed

build: remove redundant -fuse-linker-plugin from GCC LTO flags

The `-fuse-linker-plugin` flag has been automatically enabled by GCC since version 5 when LTO is active, making the explicit flag redundant. Since Node.js requires GCC >= 13.2, this flag serves no purpose. Removing it also improves portability with alternative linkers (mold, lld) that may not support GCC's linker plugin interface, avoiding build failures when these linkers are used with GCC LTO builds. Refs: yao-pkg/pkg#231 Signed-off-by: Daniel Lando <daniel.sorridi@gmail.com> PR-URL: #62667 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent fad51c2 commit 8452830
Copy full SHA for 8452830

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -189,7 +189,7 @@
189	189	['clang==1', {
190	190	'lto': ' -flto ', # Clang
191	191	}, {
192		- 'lto': ' -flto=4 -fuse-linker-plugin -ffat-lto-objects ', # GCC
	192	+ 'lto': ' -flto=4 -ffat-lto-objects ', # GCC
193	193	}],
194	194	],
195	195	},

0 commit comments

Comments

0 (0)