Commit 84603ec
http2: remove unnecessary bind from setImmediate
PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent cc9712d commit 84603ec
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2155,12 +2155,16 @@ class Http2Stream extends Duplex { | |||
| 2155 | 2155 | // By using setImmediate we allow pushStreams to make it through | |
| 2156 | 2156 | // before the stream is officially closed. This prevents a bug | |
| 2157 | 2157 | // in most browsers where those pushStreams would be rejected. | |
| 2158 | - setImmediate(this.close.bind(this)); | ||
| 2158 | + setImmediate(callStreamClose, this); | ||
| 2159 | 2159 | } | |
| 2160 | 2160 | } | |
| 2161 | 2161 | } | |
| 2162 | 2162 | } | |
| 2163 | 2163 | ||
| 2164 | + function callStreamClose(stream) { | ||
| 2165 | + stream.close(); | ||
| 2166 | + } | ||
| 2167 | + | ||
| 2164 | 2168 | function processHeaders(oldHeaders) { | |
| 2165 | 2169 | assertIsObject(oldHeaders, 'headers'); | |
| 2166 | 2170 | const headers = Object.create(null); | |
0 commit comments