Commit 84d498c
build: skip cctest on Windows shared lib build
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: #21228
Reviewed-By: Refael Ackermann <refack@gmail.com>1 parent 5d5c3fa commit 84d498c
2 files changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1001,6 +1001,10 @@ | |||
| 1001 | 1001 | ['OS=="solaris"', { | |
| 1002 | 1002 | 'ldflags': [ '-I<(SHARED_INTERMEDIATE_DIR)' ] | |
| 1003 | 1003 | }], | |
| 1004 | + # Skip cctest while building shared lib node for Windows | ||
| 1005 | + [ 'OS=="win" and node_shared=="true"', { | ||
| 1006 | + 'type': 'none', | ||
| 1007 | + }], | ||
| 1004 | 1008 | ], | |
| 1005 | 1009 | } | |
| 1006 | 1010 | ], # end targets | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -529,6 +529,7 @@ if "%test_args%"=="" goto test-v8 | |||
| 529 | 529 | if "%config%"=="Debug" set test_args=--mode=debug %test_args% | |
| 530 | 530 | if "%config%"=="Release" set test_args=--mode=release %test_args% | |
| 531 | 531 | if defined no_cctest echo Skipping cctest because no-cctest was specified && goto run-test-py | |
| 532 | + if not exist %config%\cctest.exe goto run-test-py | ||
| 532 | 533 | echo running 'cctest %cctest_args%' | |
| 533 | 534 | "%config%\cctest" %cctest_args% | |
| 534 | 535 | :run-test-py | |
0 commit comments