Commit 84efadf
test, util: refactor isObject in test-util
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected
PR-URL: #28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 0b6a84a commit 84efadf
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -73,7 +73,11 @@ assert.strictEqual(util.isError([]), false); | |||
| 73 | 73 | assert.strictEqual(util.isError(Object.create(Error.prototype)), true); | |
| 74 | 74 | ||
| 75 | 75 | // isObject | |
| 76 | - assert.ok(util.isObject({}) === true); | ||
| 76 | + assert.strictEqual(util.isObject({}), true); | ||
| 77 | + assert.strictEqual(util.isObject([]), true); | ||
| 78 | + assert.strictEqual(util.isObject(new Number(3)), true); | ||
| 79 | + assert.strictEqual(util.isObject(Number(4)), false); | ||
| 80 | + assert.strictEqual(util.isObject(1), false); | ||
| 77 | 81 | ||
| 78 | 82 | // isPrimitive | |
| 79 | 83 | assert.strictEqual(util.isPrimitive({}), false); | |
0 commit comments