v8,tools: expose experimental wasm revectorize feature · nodejs/node@84f98e0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 84f98e0

Browse filesBrowse the repository at this point in the historyBrowse files

yolanda15

authored and

aduh95

committed

v8,tools: expose experimental wasm revectorize feature

PR-URL: #54896 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 08e5309 commit 84f98e0
Copy full SHA for 84f98e0

3 files changed

+20-1Lines changed: 20 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• configure.py
• tools/v8_gypfiles
  • features.gypi
  • v8.gyp

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1685,6 +1685,9 @@ def configure_v8(o, configs):
1685	1685	raise Exception(
1686	1686	'Only one of the --v8-enable-object-print or --v8-disable-object-print options '
1687	1687	'can be specified at a time.')
	1688	+ if sys.platform != 'darwin':
	1689	+ if o['variables']['v8_enable_webassembly'] and o['variables']['target_arch'] == 'x64':
	1690	+ o['variables']['v8_enable_wasm_simd256_revec'] = 1
1688	1691
1689	1692	def configure_openssl(o):
1690	1693	variables = o['variables']

Collapse file

‎tools/v8_gypfiles/features.gypi‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/features.gypi

+7-1Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -328,7 +328,10 @@
328	328
329	329	# Enable advanced BigInt algorithms, costing about 10-30 KiB binary size
330	330	# depending on platform.
331		- 'v8_advanced_bigint_algorithms%': 1
	331	+ 'v8_advanced_bigint_algorithms%': 1,
	332	+
	333	+ # Enable 256-bit long vector re-vectorization pass in WASM compilation pipeline.
	334	+ 'v8_enable_wasm_simd256_revec%' : 0
332	335	},
333	336
334	337	'target_defaults': {
@@ -541,6 +544,9 @@
541	544	['v8_advanced_bigint_algorithms==1', {
542	545	'defines': ['V8_ADVANCED_BIGINT_ALGORITHMS',],
543	546	}],
	547	+ ['v8_enable_wasm_simd256_revec==1', {
	548	+ 'defines': ['V8_ENABLE_WASM_SIMD256_REVEC',],
	549	+ }],
544	550	], # conditions
545	551	'defines': [
546	552	'V8_GYP_BUILD',

Collapse file

‎tools/v8_gypfiles/v8.gyp‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -646,6 +646,11 @@
646	646	'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_header_set.\\"v8_internal_headers\\".*?v8_enable_webassembly.*?sources \\+= ")',
647	647	],
648	648	}],
	649	+ ['v8_enable_wasm_simd256_revec==1', {
	650	+ 'sources': [
	651	+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_header_set.\\"v8_internal_headers\\".*?v8_enable_wasm_simd256_revec.*?sources \\+= ")',
	652	+ ],
	653	+ }],
649	654	['v8_enable_i18n_support==1', {
650	655	'sources': [
651	656	'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_header_set.\\"v8_internal_headers\\".*?v8_enable_i18n_support.*?sources \\+= ")',
@@ -882,6 +887,11 @@
882	887	'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_compiler_sources =.*?v8_enable_webassembly.*?v8_compiler_sources \\+= ")',
883	888	],
884	889	}],
	890	+ ['v8_enable_wasm_simd256_revec==1', {
	891	+ 'sources': [
	892	+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_compiler_sources =.*?v8_enable_wasm_simd256_revec.*?v8_compiler_sources \\+= ")',
	893	+ ],
	894	+ }],
885	895	],
886	896	}
887	897	}, # v8_compiler_sources

0 commit comments

Comments

0 (0)