| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent b4ebe6d commit 85f88c6
5 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ | |||
| 37 | 37 | ||
| 38 | 38 | # Reset this number to 0 on major V8 upgrades. | |
| 39 | 39 | # Increment by one for each non-official patch applied to deps/v8. | |
| 40 | - 'v8_embedder_string': '-node.25', | ||
| 40 | + 'v8_embedder_string': '-node.26', | ||
| 41 | 41 | ||
| 42 | 42 | ##### V8 defaults for Node.js ##### | |
| 43 | 43 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -722,6 +722,11 @@ MaybeHandle<String> FormatDateTime(Isolate* isolate, | |||
| 722 | 722 | icu::UnicodeString result; | |
| 723 | 723 | date_format.format(date_value, result); | |
| 724 | 724 | ||
| 725 | + // Revert ICU 72 change that introduced U+202F instead of U+0020 | ||
| 726 | + // to separate time from AM/PM. See https://crbug.com/1414292. | ||
| 727 | + result = result.findAndReplace(icu::UnicodeString(0x202f), | ||
| 728 | + icu::UnicodeString(0x20)); | ||
| 729 | + | ||
| 725 | 730 | return Intl::ToString(isolate, result); | |
| 726 | 731 | } | |
| 727 | 732 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -437,6 +437,9 @@ | |||
| 437 | 437 | ||
| 438 | 438 | # noi18n is required for Intl | |
| 439 | 439 | 'regress/regress-crbug-1052647': [PASS,FAIL], | |
| 440 | + | ||
| 441 | + # Tests ICU-specific behavior. | ||
| 442 | + 'regress/regress-crbug-1414292': [SKIP], | ||
| 440 | 443 | }], # 'no_i18n' | |
| 441 | 444 | ||
| 442 | 445 | ############################################################################## | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,17 @@ | |||
| 1 | + // Copyright 2023 the V8 project authors. All rights reserved. | ||
| 2 | + // Use of this source code is governed by a BSD-style license that can be | ||
| 3 | + // found in the LICENSE file. | ||
| 4 | + | ||
| 5 | + const date = new Date("Wed Feb 15 2023 00:00:00 GMT+0100"); | ||
| 6 | + const localeString = date.toLocaleString("en-US"); | ||
| 7 | + // No narrow-width space should be found | ||
| 8 | + assertEquals(-1, localeString.search('\u202f')); | ||
| 9 | + // Regular space should match the character between time and AM/PM. | ||
| 10 | + assertMatches(/:\d\d:\d\d [AP]M$/, localeString); | ||
| 11 | + | ||
| 12 | + const formatter = new Intl.DateTimeFormat('en', {timeStyle: "long"}) | ||
| 13 | + const formattedString = formatter.format(date) | ||
| 14 | + // No narrow-width space should be found | ||
| 15 | + assertEquals(-1, formattedString.search('\u202f')); | ||
| 16 | + // Regular space should match the character between time and AM/PM. | ||
| 17 | + assertMatches(/:\d\d:\d\d [AP]M$/, localeString); | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -659,6 +659,10 @@ | |||
| 659 | 659 | 'language/expressions/assignmenttargettype/direct-callexpression-arguments': [FAIL], | |
| 660 | 660 | 'language/expressions/assignmenttargettype/parenthesized-callexpression-arguments': [FAIL], | |
| 661 | 661 | ||
| 662 | + # We replace U+202F (narrow-width space) with U+0020 (regular space). | ||
| 663 | + # https://crbug.com/1414292 | ||
| 664 | + 'intl402/DateTimeFormat/prototype/format/timedatestyle-en': [FAIL], | ||
| 665 | + | ||
| 662 | 666 | ############################ INVALID TESTS ############################# | |
| 663 | 667 | ||
| 664 | 668 | # Test makes unjustified assumptions about the number of calls to SortCompare. | |
| Back | FazBrowse Home | New Git URL |
0 commit comments