Commit 85ffc2f
test: remove sha from test expectations
"sha" in OpenSSL refers to SHA-0 which was removed from OpenSSL 1.1.0
and is insecure. Replace it with SHA-256 which is present in both 1.0.2
and 1.1.0. Short of shipping a reimplementation in Node, this is an
unavoidable behavior change with 1.1.0.
PR-URL: #16130
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>1 parent bec0421 commit 85ffc2f
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -132,12 +132,12 @@ const noCapitals = /^[^A-Z]+$/; | |||
| 132 | 132 | assert(tlsCiphers.every((value) => noCapitals.test(value))); | |
| 133 | 133 | validateList(tlsCiphers); | |
| 134 | 134 | ||
| 135 | - // Assert that we have sha and sha1 but not SHA and SHA1. | ||
| 135 | + // Assert that we have sha1 and sha256 but not SHA1 and SHA256. | ||
| 136 | 136 | assert.notStrictEqual(0, crypto.getHashes().length); | |
| 137 | 137 | assert(crypto.getHashes().includes('sha1')); | |
| 138 | - assert(crypto.getHashes().includes('sha')); | ||
| 138 | + assert(crypto.getHashes().includes('sha256')); | ||
| 139 | 139 | assert(!crypto.getHashes().includes('SHA1')); | |
| 140 | - assert(!crypto.getHashes().includes('SHA')); | ||
| 140 | + assert(!crypto.getHashes().includes('SHA256')); | ||
| 141 | 141 | assert(crypto.getHashes().includes('RSA-SHA1')); | |
| 142 | 142 | assert(!crypto.getHashes().includes('rsa-sha1')); | |
| 143 | 143 | validateList(crypto.getHashes()); | |
0 commit comments