buffer: cache Environment::GetCurrent to avoid repeated calls · nodejs/node@8615ea6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8615ea6

Browse filesBrowse the repository at this point in the historyBrowse files

mertcanaltin

authored and

aduh95

committed

buffer: cache Environment::GetCurrent to avoid repeated calls

PR-URL: #59043 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

1 parent 3a9aca9 commit 8615ea6
Copy full SHA for 8615ea6

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_buffer.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_buffer.cc‎

Copy file name to clipboardExpand all lines: src/node_buffer.cc

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1046,8 +1046,9 @@ void IndexOfBuffer(const FunctionCallbackInfo<Value>& args) {
1046	1046
1047	1047	enum encoding enc = static_cast<enum encoding>(args[3].As<Int32>()->Value());
1048	1048
1049		- THROW_AND_RETURN_UNLESS_BUFFER(Environment::GetCurrent(args), args[0]);
1050		- THROW_AND_RETURN_UNLESS_BUFFER(Environment::GetCurrent(args), args[1]);
	1049	+ Environment* env = Environment::GetCurrent(args);
	1050	+ THROW_AND_RETURN_UNLESS_BUFFER(env, args[0]);
	1051	+ THROW_AND_RETURN_UNLESS_BUFFER(env, args[1]);
1051	1052	ArrayBufferViewContents<char> haystack_contents(args[0]);
1052	1053	ArrayBufferViewContents<char> needle_contents(args[1]);
1053	1054	int64_t offset_i64 = args[2].As<Integer>()->Value();

0 commit comments

Comments

0 (0)