| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 6111671 commit 864fe99
12 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.13', | ||
| 39 | + 'v8_embedder_string': '-node.14', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -181,8 +181,9 @@ class JobDelegate { | |||
| 181 | 181 | /** | |
| 182 | 182 | * Returns true if the current task is called from the thread currently | |
| 183 | 183 | * running JobHandle::Join(). | |
| 184 | + * TODO(etiennep): Make pure virtual once custom embedders implement it. | ||
| 184 | 185 | */ | |
| 185 | - virtual bool IsJoiningThread() const = 0; | ||
| 186 | + virtual bool IsJoiningThread() const { return false; } | ||
| 186 | 187 | }; | |
| 187 | 188 | ||
| 188 | 189 | /** | |
@@ -219,21 +220,30 @@ class JobHandle { | |||
| 219 | 220 | * Forces all existing workers to yield ASAP but doesn’t wait for them. | |
| 220 | 221 | * Warning, this is dangerous if the Job's callback is bound to or has access | |
| 221 | 222 | * to state which may be deleted after this call. | |
| 223 | + * TODO(etiennep): Cleanup once implemented by all embedders. | ||
| 222 | 224 | */ | |
| 223 | - virtual void CancelAndDetach() = 0; | ||
| 225 | + virtual void CancelAndDetach() { Cancel(); } | ||
| 224 | 226 | ||
| 225 | 227 | /** | |
| 226 | 228 | * Returns true if there's any work pending or any worker running. | |
| 227 | 229 | */ | |
| 228 | 230 | virtual bool IsActive() = 0; | |
| 229 | 231 | ||
| 232 | + // TODO(etiennep): Clean up once all overrides are removed. | ||
| 233 | + V8_DEPRECATED("Use !IsActive() instead.") | ||
| 234 | + virtual bool IsCompleted() { return !IsActive(); } | ||
| 235 | + | ||
| 230 | 236 | /** | |
| 231 | 237 | * Returns true if associated with a Job and other methods may be called. | |
| 232 | 238 | * Returns false after Join() or Cancel() was called. This may return true | |
| 233 | 239 | * even if no workers are running and IsCompleted() returns true | |
| 234 | 240 | */ | |
| 235 | 241 | virtual bool IsValid() = 0; | |
| 236 | 242 | ||
| 243 | + // TODO(etiennep): Clean up once all overrides are removed. | ||
| 244 | + V8_DEPRECATED("Use IsValid() instead.") | ||
| 245 | + virtual bool IsRunning() { return IsValid(); } | ||
| 246 | + | ||
| 237 | 247 | /** | |
| 238 | 248 | * Returns true if job priority can be changed. | |
| 239 | 249 | */ | |
@@ -262,6 +272,10 @@ class JobTask { | |||
| 262 | 272 | * it must not call back any JobHandle methods. | |
| 263 | 273 | */ | |
| 264 | 274 | virtual size_t GetMaxConcurrency(size_t worker_count) const = 0; | |
| 275 | + | ||
| 276 | + // TODO(1114823): Clean up once all overrides are removed. | ||
| 277 | + V8_DEPRECATED("Use the version that takes |worker_count|.") | ||
| 278 | + virtual size_t GetMaxConcurrency() const { return 0; } | ||
| 265 | 279 | }; | |
| 266 | 280 | ||
| 267 | 281 | /** | |
| Back | FazBrowse Home | New Git URL |
0 commit comments